Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(186)

Issue 2202243004: Remove VERBOSE logs in (android) audio device code. (Closed)

Created:
4 years, 4 months ago by noahric
Modified:
4 years, 4 months ago
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com, audio-team_agora.io, sdk-team_agora.io, peah-webrtc
Base URL:
https://chromium.googlesource.com/external/webrtc.git@master
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Remove VERBOSE logs in (android) audio device code. When playing out, for example, you'd see 3 lines for every call to PlayoutDelay, which happens quite often (every sample?). The ones around the Playout/Recording Warning/Error are only once a second, but they don't seem to add anything. Same with Process/TimeUntilNextProcess, which just log that the method is called. BUG= Committed: https://crrev.com/34732882964edf3a0f7434f215dc2ec1cb2c9421 Cr-Commit-Position: refs/heads/master@{#13763}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -10 lines) Patch
M webrtc/modules/audio_device/android/audio_device_template.h View 3 chunks +0 lines, -6 lines 0 comments Download
M webrtc/modules/audio_device/audio_device_impl.cc View 4 chunks +0 lines, -4 lines 0 comments Download

Messages

Total messages: 11 (6 generated)
noahric
Hey all, some of these are pretty crazy verbose, so I removed them. Let me ...
4 years, 4 months ago (2016-08-09 16:54:24 UTC) #2
henrika_webrtc
LGTM
4 years, 4 months ago (2016-08-15 14:27:01 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2202243004/1
4 years, 4 months ago (2016-08-15 20:22:48 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 4 months ago (2016-08-15 20:41:22 UTC) #9
commit-bot: I haz the power
4 years, 4 months ago (2016-08-15 20:41:32 UTC) #11
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/34732882964edf3a0f7434f215dc2ec1cb2c9421
Cr-Commit-Position: refs/heads/master@{#13763}

Powered by Google App Engine
This is Rietveld 408576698