Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(788)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2202193002: Migrated GN target rtpcat. (Closed)

Created:
4 years, 4 months ago by aleloi
Modified:
4 years, 4 months ago
Reviewers:
kjellander_webrtc
CC:
webrtc-reviews_webrtc.org, kwiberg-webrtc, tlegrand-webrtc, tterriberry_mozilla.com, audio-team_agora.io, hlundin-webrtc, peah-webrtc, minyue-webrtc
Base URL:
https://chromium.googlesource.com/external/webrtc.git@master
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Migrated GN target rtpcat. BUG=6162 Committed: https://crrev.com/5556dcb24cfa4a0f01efe8ceb5a528310c433d6d Cr-Commit-Position: refs/heads/master@{#13605}

Patch Set 1 #

Patch Set 2 : "Rebase on top of master." #

Unified diffs Side-by-side diffs Delta from patch set Stats (+15 lines, -0 lines) Patch
M webrtc/modules/audio_coding/BUILD.gn View 1 1 chunk +14 lines, -0 lines 0 comments Download
M webrtc/modules/audio_coding/neteq/neteq_tests.gypi View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
aleloi
Aaand the last one! Please PTAL.
4 years, 4 months ago (2016-08-02 09:10:54 UTC) #2
kjellander_webrtc
lgtm
4 years, 4 months ago (2016-08-02 11:18:48 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2202193002/20001
4 years, 4 months ago (2016-08-02 11:26:15 UTC) #5
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 4 months ago (2016-08-02 11:27:28 UTC) #6
commit-bot: I haz the power
4 years, 4 months ago (2016-08-02 11:27:37 UTC) #8
Message was sent while issue was closed. 
Patchset 2 (id:??) landed as
https://crrev.com/5556dcb24cfa4a0f01efe8ceb5a528310c433d6d
Cr-Commit-Position: refs/heads/master@{#13605}

Powered by Google App Engine
This is Rietveld 408576698