Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(171)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2201883004: Migrated GN target RTPtimeshift. (Closed)

Created:
4 years, 4 months ago by aleloi
Modified:
4 years, 4 months ago
Reviewers:
kjellander_webrtc
CC:
webrtc-reviews_webrtc.org, kwiberg-webrtc, tlegrand-webrtc, tterriberry_mozilla.com, audio-team_agora.io, hlundin-webrtc, peah-webrtc, minyue-webrtc
Base URL:
https://chromium.googlesource.com/external/webrtc.git@master
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Migrated GN target RTPtimeshift. NOTRY=true BUG=6162 Committed: https://crrev.com/5a746505228ddeeb165237707487a9b2a84bf390 Cr-Commit-Position: refs/heads/master@{#13607}

Patch Set 1 #

Patch Set 2 : Rebase on top of master. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+13 lines, -0 lines) Patch
M webrtc/modules/audio_coding/BUILD.gn View 1 1 chunk +13 lines, -0 lines 0 comments Download

Messages

Total messages: 17 (9 generated)
aleloi
Another GN tool migration. Could you PTAL?
4 years, 4 months ago (2016-08-02 09:02:58 UTC) #2
kjellander_webrtc
lgtm
4 years, 4 months ago (2016-08-02 11:23:19 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2201883004/20001
4 years, 4 months ago (2016-08-02 11:26:41 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: android_arm64_rel on master.tryserver.webrtc (JOB_FAILED, http://build.chromium.org/p/tryserver.webrtc/builders/android_arm64_rel/builds/9782)
4 years, 4 months ago (2016-08-02 12:38:29 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2201883004/20001
4 years, 4 months ago (2016-08-02 13:05:08 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2201883004/20001
4 years, 4 months ago (2016-08-02 13:06:10 UTC) #13
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 4 months ago (2016-08-02 13:06:38 UTC) #15
commit-bot: I haz the power
4 years, 4 months ago (2016-08-02 13:06:49 UTC) #17
Message was sent while issue was closed. 
Patchset 2 (id:??) landed as
https://crrev.com/5a746505228ddeeb165237707487a9b2a84bf390
Cr-Commit-Position: refs/heads/master@{#13607}

Powered by Google App Engine
This is Rietveld 408576698