Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(155)

Unified Diff: webrtc/webrtc_tests.gypi

Issue 2200623003: Remove negative include rules from webrtc_nonparallel_tests target (Closed) Base URL: https://chromium.googlesource.com/external/webrtc.git@master
Patch Set: Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« webrtc/BUILD.gn ('K') | « webrtc/BUILD.gn ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: webrtc/webrtc_tests.gypi
diff --git a/webrtc/webrtc_tests.gypi b/webrtc/webrtc_tests.gypi
index f1217eba1cb828c144a75deb722c318dbcf20a11..9a1ba386d60519d5eed7d7ffec3024e71a448369 100644
--- a/webrtc/webrtc_tests.gypi
+++ b/webrtc/webrtc_tests.gypi
@@ -470,9 +470,6 @@
'type': '<(gtest_target_type)',
'sources': [
'base/nullsocketserver_unittest.cc',
- 'base/physicalsocketserver_unittest.cc',
- 'base/socket_unittest.cc',
- 'base/socket_unittest.h',
'base/socketaddress_unittest.cc',
'base/virtualsocket_unittest.cc',
],
@@ -492,16 +489,18 @@
}],
['OS=="win"', {
'sources': [
- 'base/win32socketserver_unittest.cc',
+ # TODO(ronghuawu): Fix TestUdpReadyToSendIPv6 on windows bot
+ # then reenable these tests.
+ # 'base/win32socketserver_unittest.cc',
],
- 'sources!': [
- # TODO(ronghuawu): Fix TestUdpReadyToSendIPv6 on windows bot
- # then reenable these tests.
- # TODO(pbos): Move test disabling to ifdefs within the test files
- # instead of here.
+ }],
kjellander_webrtc 2016/08/01 19:37:32 Replace line 496-497 with: }, {
danilchap 2016/08/02 07:49:37 Done.
+ ['OS!="win"', {
+ # TODO(pbos): Move test disabling to ifdefs within the test files
+ # instead of here.
+ 'sources': [
'base/physicalsocketserver_unittest.cc',
'base/socket_unittest.cc',
- 'base/win32socketserver_unittest.cc',
+ 'base/socket_unittest.h',
],
}],
['OS=="mac"', {
« webrtc/BUILD.gn ('K') | « webrtc/BUILD.gn ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698