Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(731)

Issue 2200623003: Remove negative include rules from webrtc_nonparallel_tests target (Closed)

Created:
4 years, 4 months ago by danilchap
Modified:
4 years, 4 months ago
Reviewers:
kjellander_webrtc
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com, qiang.lu, niklas.enbom, yujie_mao (webrtc), peah-webrtc
Base URL:
https://chromium.googlesource.com/external/webrtc.git@master
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Remove negative include rules from webrtc_nonparallel_tests target R=kjellander@webrtc.org BUG=webrtc:6040 Committed: https://crrev.com/b4ad456ba05ae04d479732dadaff3c49e01fa4ba Cr-Commit-Position: refs/heads/master@{#13603}

Patch Set 1 #

Total comments: 5

Patch Set 2 : Feedback #

Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -17 lines) Patch
M webrtc/BUILD.gn View 1 2 chunks +4 lines, -7 lines 0 comments Download
M webrtc/webrtc_tests.gypi View 1 2 chunks +8 lines, -10 lines 0 comments Download

Messages

Total messages: 9 (3 generated)
danilchap
4 years, 4 months ago (2016-08-01 09:58:30 UTC) #1
kjellander_webrtc
lgtm with comments addressed. https://codereview.webrtc.org/2200623003/diff/1/webrtc/BUILD.gn File webrtc/BUILD.gn (right): https://codereview.webrtc.org/2200623003/diff/1/webrtc/BUILD.gn#newcode708 webrtc/BUILD.gn:708: # sources += [ "base/win32socketserver_unittest.cc" ...
4 years, 4 months ago (2016-08-01 19:37:32 UTC) #2
danilchap
https://codereview.webrtc.org/2200623003/diff/1/webrtc/BUILD.gn File webrtc/BUILD.gn (right): https://codereview.webrtc.org/2200623003/diff/1/webrtc/BUILD.gn#newcode710 webrtc/BUILD.gn:710: if (!is_win) { On 2016/08/01 19:37:31, kjellander_webrtc wrote: > ...
4 years, 4 months ago (2016-08-02 07:49:37 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2200623003/20001
4 years, 4 months ago (2016-08-02 09:25:29 UTC) #6
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 4 months ago (2016-08-02 09:30:06 UTC) #7
commit-bot: I haz the power
4 years, 4 months ago (2016-08-02 09:30:19 UTC) #9
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/b4ad456ba05ae04d479732dadaff3c49e01fa4ba
Cr-Commit-Position: refs/heads/master@{#13603}

Powered by Google App Engine
This is Rietveld 408576698