Removed target rtp_to_text

Removed target rtp_to_text. The code does not even run.

NOTRY=True

BUG=webrtc:6162, webrtc:2692
Committed: https://crrev.com/e5106e75da50b4571de679e143b3279af3282488
Cr-Commit-Position: refs/heads/master@{#13692}

[aleloi, 2016-08-01 15:26:33]

aleloi@webrtc.org changed reviewers:
+ kjellander@webrtc.org

[aleloi, 2016-08-01 15:26:33]

I am not sure about this target. See inline comments below. 

This is a Gyp->GN migration of rtp_to_text in neteq/test.

https://codereview.webrtc.org/2199803002/diff/1/webrtc/modules/audio_coding/B...
File webrtc/modules/audio_coding/BUILD.gn (right):

https://codereview.webrtc.org/2199803002/diff/1/webrtc/modules/audio_coding/B...
webrtc/modules/audio_coding/BUILD.gn:1212: executable("rtp_to_text") {
This seems unused or deprecated. There is a 'return -1' in the main loop, and it
uses DataLog which is not used anywhere else and has no implementation. Can I
get confirmation on this and should we skip this target?

[kjellander_webrtc, 2016-08-01 19:03:42]

kjellander@webrtc.org changed reviewers:
+ henrik.lundin@webrtc.org

[kjellander_webrtc, 2016-08-01 19:03:43]

+henrik.lundin

Tools like this is not the highest of priority anyway. Getting all our unit
tests over to GN is highest prio.

https://codereview.webrtc.org/2199803002/diff/1/webrtc/modules/audio_coding/B...
File webrtc/modules/audio_coding/BUILD.gn (right):

https://codereview.webrtc.org/2199803002/diff/1/webrtc/modules/audio_coding/B...
webrtc/modules/audio_coding/BUILD.gn:1212: executable("rtp_to_text") {
On 2016/08/01 15:26:33, aleloi wrote:
> This seems unused or deprecated. There is a 'return -1' in the main loop, and
it
> uses DataLog which is not used anywhere else and has no implementation. Can I
> get confirmation on this and should we skip this target?

Let's see what Henrik L has to say. I believe he added it.

[aleloi, 2016-08-08 13:53:10]

I asked hlundin@ about this. After some git archaeology, we found that the code
has been in the same broken state since 2012. It seems safe to assume that it
hasn't been used since then as well. Therefore I removed the source and the Gyp
target. 

hlundin@: please complain if this is an incorrect description of events!

[aleloi, 2016-08-08 13:53:43]

Description was changed from

==========
Migrated target rtp_to_text.
==========

to

==========
Migrated target rtp_to_text.

BUG=webrtc:6162
==========

[kjellander_webrtc, 2016-08-08 14:04:06]

lgtm :)

[hlundin-webrtc, 2016-08-09 13:41:51]

Description was changed from

==========
Migrated target rtp_to_text.

BUG=webrtc:6162
==========

to

==========
Removed target rtp_to_text. The code does not even run.

BUG=webrtc:6162
==========

[hlundin-webrtc, 2016-08-09 13:42:51]

Description was changed from

==========
Removed target rtp_to_text. The code does not even run.

BUG=webrtc:6162
==========

to

==========
Removed target rtp_to_text. The code does not even run.

BUG=webrtc:6162, webrtc:2692
==========

[hlundin-webrtc, 2016-08-09 13:43:07]

lgtm

[aleloi, 2016-08-09 13:51:54]

Description was changed from

==========
Removed target rtp_to_text. The code does not even run.

BUG=webrtc:6162, webrtc:2692
==========

to

==========
Removed target rtp_to_text. The code does not even run.

NOTRY=True

BUG=webrtc:6162, webrtc:2692
==========

[aleloi, 2016-08-09 13:52:00]

The CQ bit was checked by aleloi@webrtc.org

[commit-bot: I haz the power, 2016-08-09 13:52:16]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...

[commit-bot: I haz the power, 2016-08-09 13:56:12]

Description was changed from

==========
Removed target rtp_to_text. The code does not even run.

NOTRY=True

BUG=webrtc:6162, webrtc:2692
==========

to

==========
Removed target rtp_to_text. The code does not even run.

NOTRY=True

BUG=webrtc:6162, webrtc:2692
==========

[commit-bot: I haz the power, 2016-08-09 13:56:13]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-08-09 13:56:23]

Description was changed from

==========
Removed target rtp_to_text. The code does not even run.

NOTRY=True

BUG=webrtc:6162, webrtc:2692
==========

to

==========
Removed target rtp_to_text. The code does not even run.

NOTRY=True

BUG=webrtc:6162, webrtc:2692

Committed: https://crrev.com/e5106e75da50b4571de679e143b3279af3282488
Cr-Commit-Position: refs/heads/master@{#13692}
==========

[commit-bot: I haz the power, 2016-08-09 13:56:25]

Patchset 2 (id:??) landed as
https://crrev.com/e5106e75da50b4571de679e143b3279af3282488
Cr-Commit-Position: refs/heads/master@{#13692}