Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(874)

Issue 2196703002: Temporarily remove problematic dcheck (Closed)

Created:
4 years, 4 months ago by sprang_webrtc
Modified:
4 years, 4 months ago
Reviewers:
stefan-webrtc
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com, zhuangzesen_agora.io, danilchap, stefan-webrtc, mflodman
Base URL:
https://chromium.googlesource.com/external/webrtc.git@master
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Temporarily remove problematic dcheck It's being triggered in some upstream code, let's disable this while we fix that. BUG= R=stefan@webrtc.org Committed: https://crrev.com/b77bd81a4a967b03aad56a9afb4583f46c5627e4 Cr-Commit-Position: refs/heads/master@{#13575}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -2 lines) Patch
M webrtc/modules/rtp_rtcp/source/rtp_sender.cc View 1 chunk +0 lines, -2 lines 0 comments Download

Messages

Total messages: 11 (6 generated)
sprang_webrtc
4 years, 4 months ago (2016-07-29 12:51:55 UTC) #2
stefan-webrtc
lgtm
4 years, 4 months ago (2016-07-29 12:54:52 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2196703002/1
4 years, 4 months ago (2016-07-29 12:56:11 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: android_arm64_rel on master.tryserver.webrtc (JOB_FAILED, http://build.chromium.org/p/tryserver.webrtc/builders/android_arm64_rel/builds/9684)
4 years, 4 months ago (2016-07-29 13:06:28 UTC) #8
sprang_webrtc
4 years, 4 months ago (2016-07-29 13:20:35 UTC) #10
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
b77bd81a4a967b03aad56a9afb4583f46c5627e4 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698