webrtc/modules/rtp_rtcp/source/rtcp_packet/transport_feedback.cc - Issue 2196563003: Remove faulty DCHECK in rtcp::TransportFeedback::ParseFrom

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: webrtc/modules/rtp_rtcp/source/rtcp_packet/transport_feedback.cc

Issue 2196563003: Remove faulty DCHECK in rtcp::TransportFeedback::ParseFrom (Closed) Base URL: https://chromium.googlesource.com/external/webrtc.git@master

Patch Set: Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: webrtc/modules/rtp_rtcp/source/rtcp_packet/transport_feedback.cc

diff --git a/webrtc/modules/rtp_rtcp/source/rtcp_packet/transport_feedback.cc b/webrtc/modules/rtp_rtcp/source/rtcp_packet/transport_feedback.cc

index 356263e96f1a4560e60c50fca38777218abed174..781d9d3e3ea80b8adfa7908715d30a7629d59759 100644

--- a/webrtc/modules/rtp_rtcp/source/rtcp_packet/transport_feedback.cc

+++ b/webrtc/modules/rtp_rtcp/source/rtcp_packet/transport_feedback.cc

@@ -744,7 +744,6 @@ std::unique_ptr<TransportFeedback> TransportFeedback::ParseFrom(

}

- RTC_DCHECK_GE(index, end_index - 3);

RTC_DCHECK_LE(index, end_index);

return packet;

« no previous file with comments | « no previous file | no next file » | no next file with comments »