remoting/client/gl_desktop.h - Issue 2196493002: [Chromoting] Unit Tests for GlRenderer

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: remoting/client/gl_desktop.h

Issue 2196493002: [Chromoting] Unit Tests for GlRenderer (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Add unittest Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: remoting/client/gl_desktop.h

diff --git a/remoting/client/gl_desktop.h b/remoting/client/gl_desktop.h

index ca7a5ee69a2993de608a40fe0cf89da2350f4b49..05962618d7a10a24918ba938bf6803a6ef94a4d5 100644

--- a/remoting/client/gl_desktop.h

+++ b/remoting/client/gl_desktop.h

@@ -26,7 +26,7 @@ class GlDesktop {

virtual ~GlDesktop();

// |frame| can be either a full frame or updated regions only frame.

- void SetVideoFrame(std::unique_ptr<webrtc::DesktopFrame> frame);

+ void SetVideoFrame(const webrtc::DesktopFrame& frame);

Yuwei 2016/07/29 00:07:02 Changed this to const ref since GlDesktop no longe

// Sets the canvas on which the desktop will be drawn. Caller must feed a

// full desktop frame after calling this function.