[Chromoting] Unit Tests for GlRenderer

remoting/client/BUILD.gn

 # Copyright 2014 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
 import("//remoting/remoting_srcs.gni")
 
 static_library("client") {
   # Disabled the source filters because there are _mac files that need to
   # be compiled on all platforms.
   set_sources_assignment_filter([])
@@ skipping 69 matching lines @@
   # be compiled on all platforms.
   set_sources_assignment_filter([])
   sources = [
     "audio_decode_scheduler_unittest.cc",
     "audio_player_unittest.cc",
     "chromoting_client_runtime_unittest.cc",
     "client_status_logger_unittest.cc",
     "client_telemetry_logger_unittest.cc",
     "dual_buffer_frame_consumer_unittest.cc",
     "empty_cursor_filter_unittest.cc",
+    "gl_renderer.cc",

[Sergey Ulanov, 2016/08/01 21:33:05]

This would meant that gl_renderer.cc is compiled twice, which we need to avoid.
Instead you should add dependency on opengl_renderer. This list shouldn't
include any files beside *unittest.cc 
Also I think you want to add gl_renderer_unittest.cc only on platforms that it
supports. Potentially it should be possible to make it work on linux, and mac as
well - that would make it easier to debug these tests.

[Yuwei, 2016/08/02 00:13:10]

Obsolete.

+    "gl_renderer.h",
+    "gl_renderer_unittest.cc",
     "key_event_mapper_unittest.cc",
     "normalizing_input_filter_cros_unittest.cc",
     "normalizing_input_filter_mac_unittest.cc",
     "normalizing_input_filter_win_unittest.cc",
     "server_log_entry_client_unittest.cc",
     "software_video_renderer_unittest.cc",
     "touch_input_scaler_unittest.cc",
   ]
   set_sources_assignment_filter(sources_assignment_filter)
 
   configs += [
     "//remoting:version",
     "//remoting:enable_webrtc_remoting_client",
   ]
 
   deps = [
     ":client",
     ":test_support",
     "//remoting/proto",
     "//testing/gmock",
     "//testing/gtest",
     "//third_party/webrtc",
   ]
 }