Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(42)

Issue 2196283002: Gyp->GN migration of RTPjitter. (Closed)

Created:
4 years, 4 months ago by aleloi
Modified:
4 years, 4 months ago
Reviewers:
kjellander_webrtc
CC:
webrtc-reviews_webrtc.org, kwiberg-webrtc, tlegrand-webrtc, tterriberry_mozilla.com, audio-team_agora.io, hlundin-webrtc, peah-webrtc, minyue-webrtc
Base URL:
https://chromium.googlesource.com/external/webrtc.git@master
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Gyp->GN migration of RTPjitter. BUG=6162 NOTRY=True Committed: https://crrev.com/17dfa7425fbf8c54849c69b30e279cc8b31f004f Cr-Commit-Position: refs/heads/master@{#13620}

Patch Set 1 #

Total comments: 2

Patch Set 2 : Added webrtc_common dependency to RTPjitter Gyp target. #

Patch Set 3 : Rebase on top of master. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -0 lines) Patch
M webrtc/modules/audio_coding/BUILD.gn View 1 2 1 chunk +11 lines, -0 lines 0 comments Download
M webrtc/modules/audio_coding/neteq/neteq_tests.gypi View 1 2 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 19 (10 generated)
aleloi
Could you please take a look at this Gyp->GN migrated target? https://codereview.webrtc.org/2196283002/diff/1/webrtc/modules/audio_coding/BUILD.gn File webrtc/modules/audio_coding/BUILD.gn (right): ...
4 years, 4 months ago (2016-08-01 15:01:06 UTC) #2
kjellander_webrtc
lgtm with a suggestion. https://codereview.webrtc.org/2196283002/diff/1/webrtc/modules/audio_coding/BUILD.gn File webrtc/modules/audio_coding/BUILD.gn (right): https://codereview.webrtc.org/2196283002/diff/1/webrtc/modules/audio_coding/BUILD.gn#newcode1215 webrtc/modules/audio_coding/BUILD.gn:1215: "../..:webrtc_common", On 2016/08/01 15:01:06, aleloi ...
4 years, 4 months ago (2016-08-01 19:10:13 UTC) #3
kjellander_webrtc
On 2016/08/01 19:10:13, kjellander_webrtc wrote: > lgtm with a suggestion. > > https://codereview.webrtc.org/2196283002/diff/1/webrtc/modules/audio_coding/BUILD.gn > File ...
4 years, 4 months ago (2016-08-01 19:10:52 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2196283002/20001
4 years, 4 months ago (2016-08-02 08:49:04 UTC) #8
commit-bot: I haz the power
Try jobs failed on following builders: android_arm64_rel on master.tryserver.webrtc (JOB_FAILED, http://build.chromium.org/p/tryserver.webrtc/builders/android_arm64_rel/builds/9771)
4 years, 4 months ago (2016-08-02 11:40:33 UTC) #10
kjellander_webrtc
On 2016/08/02 11:40:33, commit-bot: I haz the power wrote: > Try jobs failed on following ...
4 years, 4 months ago (2016-08-02 11:44:21 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2196283002/40001
4 years, 4 months ago (2016-08-03 08:16:10 UTC) #15
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years, 4 months ago (2016-08-03 08:17:28 UTC) #17
commit-bot: I haz the power
4 years, 4 months ago (2016-08-03 08:17:37 UTC) #19
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/17dfa7425fbf8c54849c69b30e279cc8b31f004f
Cr-Commit-Position: refs/heads/master@{#13620}

Powered by Google App Engine
This is Rietveld 408576698