Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2195663002:
Add sanity check for arrival timestamps. (Closed)
|
Created:
4 years, 4 months ago by sprang_webrtc Modified:
4 years, 4 months ago Reviewers:
stefan-webrtc CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com, zhuangzesen_agora.io, stefan-webrtc, mflodman Base URL:
https://chromium.googlesource.com/external/webrtc.git@master Target Ref:
refs/pending/heads/master Project:
webrtc Visibility:
Public. |
DescriptionAdd sanity check for arrival timestamps.
BUG=chromium:632614
Committed: https://crrev.com/9eb3d5def407f9898859889841133e5a48286c95
Cr-Commit-Position: refs/heads/master@{#13600}
Patch Set 1 #
Total comments: 2
Patch Set 2 : Typo #Messages
Total messages: 18 (8 generated)
sprang@webrtc.org changed reviewers: + stefan@webrtc.org
lgtm % nit https://codereview.webrtc.org/2195663002/diff/1/webrtc/modules/remote_bitrate... File webrtc/modules/remote_bitrate_estimator/remote_estimator_proxy.cc (right): https://codereview.webrtc.org/2195663002/diff/1/webrtc/modules/remote_bitrate... webrtc/modules/remote_bitrate_estimator/remote_estimator_proxy.cc:29: // than the numerical limit since we often covert to microseconds. convert
https://codereview.webrtc.org/2195663002/diff/1/webrtc/modules/remote_bitrate... File webrtc/modules/remote_bitrate_estimator/remote_estimator_proxy.cc (right): https://codereview.webrtc.org/2195663002/diff/1/webrtc/modules/remote_bitrate... webrtc/modules/remote_bitrate_estimator/remote_estimator_proxy.cc:29: // than the numerical limit since we often covert to microseconds. On 2016/07/29 09:20:01, stefan-webrtc (holmer) wrote: > convert Done.
The CQ bit was checked by sprang@webrtc.org
The patchset sent to the CQ was uploaded after l-g-t-m from stefan@webrtc.org Link to the patchset: https://codereview.webrtc.org/2195663002/#ps20001 (title: "Typo")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: android_arm64_rel on master.tryserver.webrtc (JOB_FAILED, http://build.chromium.org/p/tryserver.webrtc/builders/android_arm64_rel/build...)
The CQ bit was checked by sprang@webrtc.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: android_arm64_rel on master.tryserver.webrtc (JOB_TIMED_OUT, no build URL) android_dbg on master.tryserver.webrtc (JOB_TIMED_OUT, no build URL)
The CQ bit was checked by sprang@webrtc.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...
Message was sent while issue was closed.
Committed patchset #2 (id:20001)
Message was sent while issue was closed.
Description was changed from ========== Add sanity check for arrival timestamps. BUG=chromium:632614 ========== to ========== Add sanity check for arrival timestamps. BUG=chromium:632614 Committed: https://crrev.com/9eb3d5def407f9898859889841133e5a48286c95 Cr-Commit-Position: refs/heads/master@{#13600} ==========
Message was sent while issue was closed.
Patchset 2 (id:??) landed as https://crrev.com/9eb3d5def407f9898859889841133e5a48286c95 Cr-Commit-Position: refs/heads/master@{#13600} |
