Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(63)

Unified Diff: webrtc/modules/audio_mixer/source/new_audio_conference_mixer_impl.h

Issue 2195633002: Revert of Rewrote UpdateToMix in the audio mixer. (Closed) Base URL: https://chromium.googlesource.com/external/webrtc.git@remove_memory_pool
Patch Set: Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: webrtc/modules/audio_mixer/source/new_audio_conference_mixer_impl.h
diff --git a/webrtc/modules/audio_mixer/source/new_audio_conference_mixer_impl.h b/webrtc/modules/audio_mixer/source/new_audio_conference_mixer_impl.h
index f60861b96f45ec92c5b300cd642cbf9c803140b7..de6b9f4ad00b5560f3b41e740c5787e031506eeb 100644
--- a/webrtc/modules/audio_mixer/source/new_audio_conference_mixer_impl.h
+++ b/webrtc/modules/audio_mixer/source/new_audio_conference_mixer_impl.h
@@ -84,10 +84,17 @@
int32_t SetOutputFrequency(const Frequency& frequency);
Frequency OutputFrequency() const;
- // Compute what audio sources to mix from audio_source_list_. Ramp in
- // and out. Update mixed status. maxAudioFrameCounter specifies how
- // many participants are allowed to be mixed.
- AudioFrameList UpdateToMix(size_t maxAudioFrameCounter) const;
+ // Fills mixList with the AudioFrames pointers that should be used when
+ // mixing.
+ // maxAudioFrameCounter both input and output specifies how many more
+ // AudioFrames that are allowed to be mixed.
+ // rampOutList contain AudioFrames corresponding to an audio stream that
+ // used to be mixed but shouldn't be mixed any longer. These AudioFrames
+ // should be ramped out over this AudioFrame to avoid audio discontinuities.
+ void UpdateToMix(AudioFrameList* mixList,
+ AudioFrameList* rampOutList,
+ std::map<int, MixerAudioSource*>* mixAudioSourceList,
+ size_t* maxAudioFrameCounter) const;
// Return the lowest mixing frequency that can be used without having to
// downsample any audio.
@@ -97,6 +104,11 @@
// Return the AudioFrames that should be mixed anonymously.
void GetAdditionalAudio(AudioFrameList* additionalFramesList) const;
+
+ // Update the NewMixHistory of all MixerAudioSources. mixedAudioSourcesList
+ // should contain a map of MixerAudioSources that have been mixed.
+ void UpdateMixedStatus(
+ const std::map<int, MixerAudioSource*>& mixedAudioSourcesList) const;
// Clears audioFrameList and reclaims all memory associated with it.
void ClearAudioFrameList(AudioFrameList* audioFrameList) const;

Powered by Google App Engine
This is Rietveld 408576698