Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(329)

Issue 2195633002: Revert of Rewrote UpdateToMix in the audio mixer. (Closed)

Created:
4 years, 4 months ago by terelius
Modified:
4 years, 4 months ago
Reviewers:
ivoc, ossu, aleloi
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com
Base URL:
https://chromium.googlesource.com/external/webrtc.git@remove_memory_pool
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Revert of Rewrote UpdateToMix in the audio mixer. (patchset #5 id:120001 of https://codereview.webrtc.org/2132563002/ ) Reason for revert: Multiple definitions of webrtc::MockMixerParticipant::MockMixerParticipant() during linking of modules_unittests. Please investigate and resubmit. Original issue's description: > Rewrote UpdateToMix in the audio mixer. > > The new version is much shorter than the old one, and hopefully easier > to read. This is part of the effort to rewrite the old mixer. > > Committed: https://crrev.com/2942e240f4a985752714dac18c141064c97696d4 > Cr-Commit-Position: refs/heads/master@{#13568} TBR=ossu@webrtc.org,ivoc@webrtc.org,aleloi@webrtc.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true Committed: https://crrev.com/ea4c141ffa1cfa6b7ac53fab63722e6373e5db0e Cr-Commit-Position: refs/heads/master@{#13569}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+247 lines, -302 lines) Patch
M webrtc/modules/audio_mixer/include/audio_mixer_defines.h View 2 chunks +3 lines, -3 lines 0 comments Download
M webrtc/modules/audio_mixer/source/new_audio_conference_mixer_impl.h View 2 chunks +16 lines, -4 lines 0 comments Download
M webrtc/modules/audio_mixer/source/new_audio_conference_mixer_impl.cc View 8 chunks +222 lines, -95 lines 0 comments Download
M webrtc/modules/audio_mixer/test/audio_mixer_unittest.cc View 3 chunks +6 lines, -200 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
terelius
Created Revert of Rewrote UpdateToMix in the audio mixer.
4 years, 4 months ago (2016-07-29 08:36:00 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2195633002/1
4 years, 4 months ago (2016-07-29 08:36:04 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 4 months ago (2016-07-29 08:36:18 UTC) #4
commit-bot: I haz the power
4 years, 4 months ago (2016-07-29 08:36:29 UTC) #6
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/ea4c141ffa1cfa6b7ac53fab63722e6373e5db0e
Cr-Commit-Position: refs/heads/master@{#13569}

Powered by Google App Engine
This is Rietveld 408576698