Migrated target RTPencode to GN

Migrated target RTPencode to GN

TBR=henrik.lundin@webrtc.org

BUG=6162
Committed: https://crrev.com/8266773f18627a75b947efb77a0406474b4c47c3
Cr-Commit-Position: refs/heads/master@{#13599}

[aleloi, 2016-08-01 14:31:33]

aleloi@webrtc.org changed reviewers:
+ kjellander@webrtc.org

[aleloi, 2016-08-01 14:31:34]

Hi! Could you please take a look at another Gyp->GN migration?

https://codereview.webrtc.org/2195353002/diff/1/webrtc/modules/audio_coding/B...
File webrtc/modules/audio_coding/BUILD.gn (right):

https://codereview.webrtc.org/2195353002/diff/1/webrtc/modules/audio_coding/B...
webrtc/modules/audio_coding/BUILD.gn:1232: executable("RTPencode") {
Added target here instead of in neteq because other targets in neteq are also
here and neteq has no BUILD.gn file.

https://codereview.webrtc.org/2195353002/diff/1/webrtc/modules/audio_coding/B...
webrtc/modules/audio_coding/BUILD.gn:1236: # TODO(hlundin): Make RTPencode use
ACM to encode files.
Copied TODO from gyp build file.

https://codereview.webrtc.org/2195353002/diff/1/webrtc/modules/audio_coding/B...
webrtc/modules/audio_coding/BUILD.gn:1254: include_dirs = [
Removed webrtc root as it is included by default.

[aleloi, 2016-08-01 14:32:21]

https://codereview.webrtc.org/2195353002/diff/1/webrtc/modules/audio_coding/n...
File webrtc/modules/audio_coding/neteq/test/RTPencode.cc (left):

https://codereview.webrtc.org/2195353002/diff/1/webrtc/modules/audio_coding/n...
webrtc/modules/audio_coding/neteq/test/RTPencode.cc:325: printf("The coded
speech is packetized in RTP packest and written to the "
Noticed spelling mistake when I did a test run.

[aleloi, 2016-08-01 14:32:33]

The CQ bit was checked by aleloi@webrtc.org to run a CQ dry run

[commit-bot: I haz the power, 2016-08-01 14:32:46]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...

[commit-bot: I haz the power, 2016-08-01 16:33:24]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-01 16:33:25]

Dry run: Try jobs failed on following builders:
  android_arm64_rel on master.tryserver.webrtc (JOB_TIMED_OUT, no build URL)

[kjellander_webrtc, 2016-08-01 19:31:02]

lgtm but you need another owner's approval for the .cc change (but you could
TBR=henrik.lundin@webrtc.org on that).

[kjellander_webrtc, 2016-08-01 19:31:28]

On 2016/08/01 19:31:02, kjellander_webrtc wrote:
> lgtm but you need another owner's approval for the .cc change (but you could
> mailto:TBR=henrik.lundin@webrtc.org on that).

Forgot to mention: please add a BUG= line too the CL description too.

[aleloi, 2016-08-02 08:43:50]

Description was changed from

==========
Migrated target RTPencode to GN
==========

to

==========
Migrated target RTPencode to GN

TBR=henrik.lundin@webrtc.org

BUG=6162
==========

[aleloi, 2016-08-02 08:43:50]

aleloi@webrtc.org changed reviewers:
+ henrik.lundin@webrtc.org

[aleloi, 2016-08-02 08:44:23]

The CQ bit was checked by aleloi@webrtc.org

[commit-bot: I haz the power, 2016-08-02 08:44:34]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...

[commit-bot: I haz the power, 2016-08-02 08:45:53]

Description was changed from

==========
Migrated target RTPencode to GN

TBR=henrik.lundin@webrtc.org

BUG=6162
==========

to

==========
Migrated target RTPencode to GN

TBR=henrik.lundin@webrtc.org

BUG=6162
==========

[commit-bot: I haz the power, 2016-08-02 08:45:54]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2016-08-02 08:46:01]

Description was changed from

==========
Migrated target RTPencode to GN

TBR=henrik.lundin@webrtc.org

BUG=6162
==========

to

==========
Migrated target RTPencode to GN

TBR=henrik.lundin@webrtc.org

BUG=6162

Committed: https://crrev.com/8266773f18627a75b947efb77a0406474b4c47c3
Cr-Commit-Position: refs/heads/master@{#13599}
==========

[commit-bot: I haz the power, 2016-08-02 08:46:02]

Patchset 1 (id:??) landed as
https://crrev.com/8266773f18627a75b947efb77a0406474b4c47c3
Cr-Commit-Position: refs/heads/master@{#13599}

[hlundin-webrtc, 2016-08-09 12:41:16]

LGTM for the .cc file.