Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(244)

Issue 2194213002: Migrated RTPchange Gyp target to GN. (Closed)

Created:
4 years, 4 months ago by aleloi
Modified:
4 years, 4 months ago
Reviewers:
kjellander_webrtc
CC:
webrtc-reviews_webrtc.org, kwiberg-webrtc, tlegrand-webrtc, tterriberry_mozilla.com, audio-team_agora.io, hlundin-webrtc, peah-webrtc, minyue-webrtc
Base URL:
https://chromium.googlesource.com/external/webrtc.git@master
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Migrated RTPchange Gyp target to GN. BUG=6162 Committed: https://crrev.com/76cbe19f8ac292c3e8fe6f217d63c60b534d9821 Cr-Commit-Position: refs/heads/master@{#13601}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -0 lines) Patch
M webrtc/modules/audio_coding/BUILD.gn View 1 chunk +12 lines, -0 lines 0 comments Download

Messages

Total messages: 11 (5 generated)
aleloi
Could you PTAL?
4 years, 4 months ago (2016-08-01 15:12:15 UTC) #2
kjellander_webrtc
lgtm
4 years, 4 months ago (2016-08-01 19:06:14 UTC) #3
kjellander_webrtc
On 2016/08/01 19:06:14, kjellander_webrtc wrote: > lgtm Add a link to a bug in the ...
4 years, 4 months ago (2016-08-01 19:11:04 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2194213002/1
4 years, 4 months ago (2016-08-02 08:49:34 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 4 months ago (2016-08-02 09:05:10 UTC) #9
commit-bot: I haz the power
4 years, 4 months ago (2016-08-02 09:05:16 UTC) #11
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/76cbe19f8ac292c3e8fe6f217d63c60b534d9821
Cr-Commit-Position: refs/heads/master@{#13601}

Powered by Google App Engine
This is Rietveld 408576698