Issue 2193573002: Increase audio buffer duration for iPhone 4s.

Issue 2193573002: Increase audio buffer duration for iPhone 4s. (Closed)

Created:
4 years, 4 months ago by tkchin_webrtc

Modified:
4 years, 4 months ago

Reviewers:
henrika_webrtc, minyue-webrtc

CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com, audio-team_agora.io, sdk-team_agora.io, peah-webrtc

Base URL:
https://chromium.googlesource.com/external/webrtc.git@master

Target Ref:
refs/pending/heads/master

Project:
webrtc

Visibility:
Public.

Increase audio buffer duration for iPhone 4s. NOTRY=True BUG= Committed: https://crrev.com/cd2553937e3f6ccb0abf751d58b5afa24916c4da Cr-Commit-Position: refs/heads/master@{#13579}

Created: 4 years, 4 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+2 lines, -1 line)			Patch
	M	webrtc/modules/audio_device/ios/objc/RTCAudioSessionConfiguration.m	View		2 chunks	+2 lines, -1 line	0 comments	Download

Total messages: 11 (6 generated)

tkchin_webrtc

This is basically https://codereview.webrtc.org/2066993005/ I don't know what the diff between 2 and 6 is ...

4 years, 4 months ago (2016-07-28 22:31:03 UTC) #3

henrika_webrtc

I think they will be fine with 60. As long as the complexity is reduced ...

4 years, 4 months ago (2016-07-29 07:58:37 UTC) #4

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2193573002/1

4 years, 4 months ago (2016-07-29 17:52:04 UTC) #7

commit-bot: I haz the power

4 years, 4 months ago (2016-07-29 17:53:53 UTC) #11

Message was sent while issue was closed.

Patchset 1 (id:??) landed as
https://crrev.com/cd2553937e3f6ccb0abf751d58b5afa24916c4da
Cr-Commit-Position: refs/heads/master@{#13579}