Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2193043002:
congestion controller: Fix network route change handling (Closed)
Descriptioncongestion controller: Fix network route change handling
A reset of Bwe and rates on network route change triggers
switching of the RemoteBitrateEstimator from DelayBasedBwe
to RemoteBitrateEstimatorAbsSendTime. This is unexpected,
fix this.
BUG=
R=stefan@webrtc.org
Committed: https://chromium.googlesource.com/external/webrtc/+/b578d6c56bf7a07c3fcbcf2a4a617b003402e519
Patch Set 1 #
Messages
Total messages: 20 (10 generated)
Description was changed from ========== congestion controller: Fix network route change handling A reset of Bwe and rates on network route change triggers switching of the RemoteBitrateEstimator from DelayBasedBwe to RemoteBitrateEstimatorAbsSendTime. This is unexpected, fix this. BUG= ========== to ========== congestion controller: Fix network route change handling A reset of Bwe and rates on network route change triggers switching of the RemoteBitrateEstimator from DelayBasedBwe to RemoteBitrateEstimatorAbsSendTime. This is unexpected, fix this. BUG= ==========
isheriff@chromium.org changed reviewers: + philipel@webrtc.org, stefan@webrtc.org
Thanks for finding this one. If possible, it'd be great to add a test to cover this case... lgtm anyway since we really should get this in.
The CQ bit was checked by stefan@webrtc.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: android_arm64_rel on master.tryserver.webrtc (JOB_FAILED, http://build.chromium.org/p/tryserver.webrtc/builders/android_arm64_rel/build...)
The CQ bit was checked by isheriff@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: android_arm64_rel on master.tryserver.webrtc (JOB_FAILED, http://build.chromium.org/p/tryserver.webrtc/builders/android_arm64_rel/build...)
The CQ bit was checked by isheriff@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: android_arm64_rel on master.tryserver.webrtc (JOB_TIMED_OUT, no build URL) android_dbg on master.tryserver.webrtc (JOB_TIMED_OUT, no build URL)
Message was sent while issue was closed.
Description was changed from ========== congestion controller: Fix network route change handling A reset of Bwe and rates on network route change triggers switching of the RemoteBitrateEstimator from DelayBasedBwe to RemoteBitrateEstimatorAbsSendTime. This is unexpected, fix this. BUG= ========== to ========== congestion controller: Fix network route change handling A reset of Bwe and rates on network route change triggers switching of the RemoteBitrateEstimator from DelayBasedBwe to RemoteBitrateEstimatorAbsSendTime. This is unexpected, fix this. BUG= R=stefan@webrtc.org Committed: https://crrev.com/b578d6c56bf7a07c3fcbcf2a4a617b003402e519 Cr-Commit-Position: refs/heads/master@{#13594} ==========
Message was sent while issue was closed.
Description was changed from ========== congestion controller: Fix network route change handling A reset of Bwe and rates on network route change triggers switching of the RemoteBitrateEstimator from DelayBasedBwe to RemoteBitrateEstimatorAbsSendTime. This is unexpected, fix this. BUG= R=stefan@webrtc.org Committed: https://crrev.com/b578d6c56bf7a07c3fcbcf2a4a617b003402e519 Cr-Commit-Position: refs/heads/master@{#13594} ========== to ========== congestion controller: Fix network route change handling A reset of Bwe and rates on network route change triggers switching of the RemoteBitrateEstimator from DelayBasedBwe to RemoteBitrateEstimatorAbsSendTime. This is unexpected, fix this. BUG= R=stefan@webrtc.org Committed: https://chromium.googlesource.com/external/webrtc/+/b578d6c56bf7a07c3fcbcf2a4... ==========
Message was sent while issue was closed.
Patchset 1 (id:??) landed as https://crrev.com/b578d6c56bf7a07c3fcbcf2a4a617b003402e519 Cr-Commit-Position: refs/heads/master@{#13594}
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as b578d6c56bf7a07c3fcbcf2a4a617b003402e519 (presubmit successful). |
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
