Don't stop sending media on EWOULDBLOCK

Don't stop sending media on EWOULDBLOCK

This change makes WebRTC no longer stop sending video when we receive an
EWOULDBLOCK error from the operating system. This was previously
causing calls on a slow link (where the first hop is slow) to rapidly
oscillate between starting and stopping video.

We still do need to stop sending packets if there is no known good
connection we can use for that. We used to generate a synthetic
EWOULDBLOCK error in that case. This CL replaces it with a different
code (ENOTCONN); EWOULDBLOCK no longer stops the stream but ENOTCONN
does.

I've updated all the places where we seemed to be generating EWOULDBLOCK
for reasons other than some buffer been full; please give it a thorough
look in case I missed something.

R=pthatcher@webrtc.org

Committed: https://crrev.com/c309e0e3eaa90411ffedd83f50313b8b9d9826b5
Cr-Commit-Position: refs/heads/master@{#13566}

[pthatcher1, 2016-07-28 20:27:50]

pthatcher@webrtc.org changed reviewers:
+ pthatcher@webrtc.org

[pthatcher1, 2016-07-28 20:27:50]

lgtm

https://codereview.webrtc.org/2192963002/diff/1/webrtc/pc/channel.cc
File webrtc/pc/channel.cc (right):

https://codereview.webrtc.org/2192963002/diff/1/webrtc/pc/channel.cc#newcode762
webrtc/pc/channel.cc:762: LOG(LS_WARNING) << "Got ENOTCONN from socket.";
"from socket" probably isn't accurate any more.  Perhaps "from transport" would
make more sense.

[skvlad, 2016-07-28 23:59:24]

The CQ bit was checked by skvlad@webrtc.org

[skvlad, 2016-07-28 23:59:25]

The patchset sent to the CQ was uploaded after l-g-t-m from pthatcher@webrtc.org
Link to the patchset: https://codereview.webrtc.org/2192963002/#ps20001 (title:
"Don't stop sending media on EWOULDBLOCK")

[commit-bot: I haz the power, 2016-07-28 23:59:32]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...

[commit-bot: I haz the power, 2016-07-29 00:09:53]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-07-29 00:09:54]

Try jobs failed on following builders:
  android_arm64_rel on master.tryserver.webrtc (JOB_FAILED,
http://build.chromium.org/p/tryserver.webrtc/builders/android_arm64_rel/build...)

[commit-bot: I haz the power, 2016-07-29 00:15:34]

Description was changed from

==========
Don't stop sending media on EWOULDBLOCK

This change makes WebRTC no longer stop sending video when we receive an
EWOULDBLOCK error from the operating system. This was previously
causing calls on a slow link (where the first hop is slow) to rapidly
oscillate between starting and stopping video.

We still do need to stop sending packets if there is no known good
connection we can use for that. We used to generate a synthetic
EWOULDBLOCK error in that case. This CL replaces it with a different
code (ENOTCONN); EWOULDBLOCK no longer stops the stream but ENOTCONN
does.

I've updated all the places where we seemed to be generating EWOULDBLOCK
for reasons other than some buffer been full; please give it a thorough
look in case I missed something.
==========

to

==========
Don't stop sending media on EWOULDBLOCK

This change makes WebRTC no longer stop sending video when we receive an
EWOULDBLOCK error from the operating system. This was previously
causing calls on a slow link (where the first hop is slow) to rapidly
oscillate between starting and stopping video.

We still do need to stop sending packets if there is no known good
connection we can use for that. We used to generate a synthetic
EWOULDBLOCK error in that case. This CL replaces it with a different
code (ENOTCONN); EWOULDBLOCK no longer stops the stream but ENOTCONN
does.

I've updated all the places where we seemed to be generating EWOULDBLOCK
for reasons other than some buffer been full; please give it a thorough
look in case I missed something.

R=pthatcher@webrtc.org

Committed: https://crrev.com/c309e0e3eaa90411ffedd83f50313b8b9d9826b5
Cr-Commit-Position: refs/heads/master@{#13566}
==========

[skvlad, 2016-07-29 00:15:34]

Description was changed from

==========
Don't stop sending media on EWOULDBLOCK

This change makes WebRTC no longer stop sending video when we receive an
EWOULDBLOCK error from the operating system. This was previously
causing calls on a slow link (where the first hop is slow) to rapidly
oscillate between starting and stopping video.

We still do need to stop sending packets if there is no known good
connection we can use for that. We used to generate a synthetic
EWOULDBLOCK error in that case. This CL replaces it with a different
code (ENOTCONN); EWOULDBLOCK no longer stops the stream but ENOTCONN
does.

I've updated all the places where we seemed to be generating EWOULDBLOCK
for reasons other than some buffer been full; please give it a thorough
look in case I missed something.
==========

to

==========
Don't stop sending media on EWOULDBLOCK

This change makes WebRTC no longer stop sending video when we receive an
EWOULDBLOCK error from the operating system. This was previously
causing calls on a slow link (where the first hop is slow) to rapidly
oscillate between starting and stopping video.

We still do need to stop sending packets if there is no known good
connection we can use for that. We used to generate a synthetic
EWOULDBLOCK error in that case. This CL replaces it with a different
code (ENOTCONN); EWOULDBLOCK no longer stops the stream but ENOTCONN
does.

I've updated all the places where we seemed to be generating EWOULDBLOCK
for reasons other than some buffer been full; please give it a thorough
look in case I missed something.

R=pthatcher@webrtc.org

Committed:
https://chromium.googlesource.com/external/webrtc/+/c309e0e3eaa90411ffedd83f5...
==========

[commit-bot: I haz the power, 2016-07-29 00:15:35]

Patchset 2 (id:??) landed as
https://crrev.com/c309e0e3eaa90411ffedd83f50313b8b9d9826b5
Cr-Commit-Position: refs/heads/master@{#13566}

[skvlad, 2016-07-29 00:15:35]

Committed patchset #2 (id:20001) manually as
c309e0e3eaa90411ffedd83f50313b8b9d9826b5 (presubmit successful).