Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(195)

Issue 2190533004: Use a better method to generate a random ID in IvfFileWriterTest. (Closed)

Created:
4 years, 4 months ago by Taylor Brandstetter
Modified:
4 years, 4 months ago
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com, zhengzhonghou_agora.io, video-team_agora.io, mflodman
Base URL:
https://chromium.googlesource.com/external/webrtc.git@master
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Use a better method to generate a random ID in IvfFileWriterTest. It was generating a random ID using the test case's "this" pointer and the current time. However, the current time may be imprecise. And the "this" pointer may have repeatable values. BUG=webrtc:5898 Committed: https://crrev.com/55b0b3755421c7b795d78cf5836677078423a27f Cr-Commit-Position: refs/heads/master@{#13560}

Patch Set 1 #

Patch Set 2 : Un-flaking TestSrtpError by using a fake clock. #

Patch Set 3 : Reverting last patchset (was meant for another CL) #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -5 lines) Patch
M webrtc/modules/video_coding/utility/ivf_file_writer_unittest.cc View 2 chunks +5 lines, -5 lines 0 comments Download

Messages

Total messages: 11 (4 generated)
Taylor Brandstetter
4 years, 4 months ago (2016-07-27 21:29:21 UTC) #2
stefan-webrtc
sprang@ is a better reviewer for this.
4 years, 4 months ago (2016-07-28 07:14:31 UTC) #4
sprang_webrtc
lgtm
4 years, 4 months ago (2016-07-28 11:51:52 UTC) #5
stefan-webrtc
rs lgtm
4 years, 4 months ago (2016-07-28 12:27:55 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2190533004/1
4 years, 4 months ago (2016-07-28 16:46:48 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 4 months ago (2016-07-28 17:51:14 UTC) #9
commit-bot: I haz the power
4 years, 4 months ago (2016-07-28 17:51:19 UTC) #11
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/55b0b3755421c7b795d78cf5836677078423a27f
Cr-Commit-Position: refs/heads/master@{#13560}

Powered by Google App Engine
This is Rietveld 408576698