Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(315)

Issue 2190013002: Revert of Add BWE plot to event log analyzer. (Closed)

Created:
4 years, 4 months ago by terelius
Modified:
4 years, 4 months ago
Reviewers:
phoglund, stefan-webrtc
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com, the sun, pbos-webrtc, mflodman
Base URL:
https://chromium.googlesource.com/external/webrtc.git@master
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Revert of Add BWE plot to event log analyzer. (patchset #6 id:100001 of https://codereview.webrtc.org/2188033004/ ) Reason for revert: Breaks downstream targets. Original issue's description: > Add BWE plot to event log analyzer. > > The plot is constructed by actually running the congestion controller with > the logged rtp headers and rtcp feedback messages to reproduce the same behavior > as in the real call. > > R=phoglund@webrtc.org, terelius@webrtc.org > > Committed: https://crrev.com/2beea2a8c920000ef19eea20cce397507fc3d5e7 > Cr-Commit-Position: refs/heads/master@{#13558} TBR=phoglund@webrtc.org,stefan@webrtc.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true Committed: https://crrev.com/59c1ad58e6d32e0f931dda789134be002e4e9ccd Cr-Commit-Position: refs/heads/master@{#13559}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+89 lines, -264 lines) Patch
M webrtc/call/rtc_event_log.h View 2 chunks +0 lines, -35 lines 0 comments Download
M webrtc/call/rtc_event_log.cc View 1 chunk +34 lines, -0 lines 0 comments Download
M webrtc/modules/congestion_controller/congestion_controller.cc View 1 chunk +1 line, -1 line 0 comments Download
M webrtc/test/fuzzers/congestion_controller_feedback_fuzzer.cc View 1 chunk +30 lines, -1 line 0 comments Download
M webrtc/tools/BUILD.gn View 2 chunks +0 lines, -3 lines 0 comments Download
M webrtc/tools/DEPS View 1 chunk +0 lines, -1 line 0 comments Download
M webrtc/tools/event_log_visualizer/analyzer.h View 3 chunks +8 lines, -25 lines 0 comments Download
M webrtc/tools/event_log_visualizer/analyzer.cc View 9 chunks +15 lines, -181 lines 0 comments Download
M webrtc/tools/event_log_visualizer/generate_timeseries.cc View 2 chunks +0 lines, -8 lines 0 comments Download
M webrtc/tools/event_log_visualizer/plot_base.h View 1 chunk +1 line, -1 line 0 comments Download
M webrtc/tools/event_log_visualizer/plot_python.cc View 2 chunks +0 lines, -6 lines 0 comments Download
M webrtc/tools/tools.gyp View 1 chunk +0 lines, -2 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
terelius
Created Revert of Add BWE plot to event log analyzer.
4 years, 4 months ago (2016-07-28 16:21:15 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2190013002/1
4 years, 4 months ago (2016-07-28 16:21:17 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 4 months ago (2016-07-28 16:21:29 UTC) #4
commit-bot: I haz the power
4 years, 4 months ago (2016-07-28 16:21:40 UTC) #6
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/59c1ad58e6d32e0f931dda789134be002e4e9ccd
Cr-Commit-Position: refs/heads/master@{#13559}

Powered by Google App Engine
This is Rietveld 408576698