Use a newer method to bind socket to network in Android M and later.

Use a new method (android_setsocknetwork) to bind socket to network in Android M and later.
The old method (setNetworkForSocket) is not supported in Android-N.

BUG=
R=glaznev@webrtc.org, pthatcher@webrtc.org

Committed: https://crrev.com/c98006224210bb39c6427720cc62e5fbf628317b
Cr-Commit-Position: refs/heads/master@{#13591}

[honghaiz3, 2016-07-27 20:43:28]

Patchset #1 (id:1) has been deleted

[honghaiz3, 2016-07-27 20:44:45]

Description was changed from

==========
Use a newer method to bind socket to network in Android M and later.
The old method is not supported in Android-N.

BUG=
==========

to

==========
Use a new method (android_setsocknetwork) to bind socket to network in Android M
and later.
The old method (setNetworkForSocket) is not supported in Android-N.

BUG=
==========

[honghaiz3, 2016-07-27 20:54:36]

Patchset #1 (id:20001) has been deleted

[honghaiz3, 2016-07-27 20:55:34]

honghaiz@webrtc.org changed reviewers:
+ glaznev@webrtc.org, pthatcher@webrtc.org

[honghaiz3, 2016-07-27 20:55:35]

I tested this with Android-L, M, N. 
PTAL.

[AlexG, 2016-07-27 23:37:03]

lgtm

https://codereview.webrtc.org/2189753002/diff/40001/webrtc/api/android/jni/an...
File webrtc/api/android/jni/androidnetworkmonitor_jni.cc (right):

https://codereview.webrtc.org/2189753002/diff/40001/webrtc/api/android/jni/an...
webrtc/api/android/jni/androidnetworkmonitor_jni.cc:192: android_sdk_int_ =
jni()->CallStaticIntMethod(*j_network_monitor_class_, m);
Add CHECK_EXCEPTION(jni())

https://codereview.webrtc.org/2189753002/diff/40001/webrtc/api/android/jni/an...
webrtc/api/android/jni/androidnetworkmonitor_jni.cc:270: void* lib =
dlopen(android_native_lib_path.c_str(), RTLD_NOW);
Keep check for lib == nullptr ?

https://codereview.webrtc.org/2189753002/diff/40001/webrtc/api/android/jni/an...
webrtc/api/android/jni/androidnetworkmonitor_jni.cc:295: void* lib =
dlopen(net_library_path.c_str(), RTLD_NOW | RTLD_NOLOAD);
ditto: keep check for lib == nullptr?

[pthatcher1, 2016-07-29 16:20:17]

lgtm (assuming you cover Alex's comments)

[honghaiz3, 2016-07-29 17:28:18]

Thanks!

https://codereview.webrtc.org/2189753002/diff/40001/webrtc/api/android/jni/an...
File webrtc/api/android/jni/androidnetworkmonitor_jni.cc (right):

https://codereview.webrtc.org/2189753002/diff/40001/webrtc/api/android/jni/an...
webrtc/api/android/jni/androidnetworkmonitor_jni.cc:192: android_sdk_int_ =
jni()->CallStaticIntMethod(*j_network_monitor_class_, m);
On 2016/07/27 23:37:02, AlexG wrote:
> Add CHECK_EXCEPTION(jni())

Done.

https://codereview.webrtc.org/2189753002/diff/40001/webrtc/api/android/jni/an...
webrtc/api/android/jni/androidnetworkmonitor_jni.cc:270: void* lib =
dlopen(android_native_lib_path.c_str(), RTLD_NOW);
On 2016/07/27 23:37:03, AlexG wrote:
> Keep check for lib == nullptr ?

Done.

https://codereview.webrtc.org/2189753002/diff/40001/webrtc/api/android/jni/an...
webrtc/api/android/jni/androidnetworkmonitor_jni.cc:295: void* lib =
dlopen(net_library_path.c_str(), RTLD_NOW | RTLD_NOLOAD);
On 2016/07/27 23:37:02, AlexG wrote:
> ditto: keep check for lib == nullptr?

Done.

[honghaiz3, 2016-07-29 17:47:14]

The CQ bit was checked by honghaiz@webrtc.org

[honghaiz3, 2016-07-29 17:47:14]

The patchset sent to the CQ was uploaded after l-g-t-m from glaznev@webrtc.org,
pthatcher@webrtc.org
Link to the patchset: https://codereview.webrtc.org/2189753002/#ps60001 (title:
".")

[commit-bot: I haz the power, 2016-07-29 17:47:23]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...

[commit-bot: I haz the power, 2016-07-29 17:51:14]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-07-29 17:51:15]

Try jobs failed on following builders:
  android_arm64_rel on master.tryserver.webrtc (JOB_FAILED,
http://build.chromium.org/p/tryserver.webrtc/builders/android_arm64_rel/build...)
  android_compile_x64_dbg on master.tryserver.webrtc (JOB_FAILED,
http://build.chromium.org/p/tryserver.webrtc/builders/android_compile_x64_dbg...)
  android_compile_x86_dbg on master.tryserver.webrtc (JOB_FAILED,
http://build.chromium.org/p/tryserver.webrtc/builders/android_compile_x86_dbg...)

[honghaiz3, 2016-08-01 15:53:12]

The CQ bit was checked by honghaiz@webrtc.org

[honghaiz3, 2016-08-01 15:53:12]

The patchset sent to the CQ was uploaded after l-g-t-m from glaznev@webrtc.org,
pthatcher@webrtc.org
Link to the patchset: https://codereview.webrtc.org/2189753002/#ps80001 (title:
"Fix a test")

[commit-bot: I haz the power, 2016-08-01 15:53:20]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...

[honghaiz3, 2016-08-01 16:27:46]

Description was changed from

==========
Use a new method (android_setsocknetwork) to bind socket to network in Android M
and later.
The old method (setNetworkForSocket) is not supported in Android-N.

BUG=
==========

to

==========
Use a new method (android_setsocknetwork) to bind socket to network in Android M
and later.
The old method (setNetworkForSocket) is not supported in Android-N.

BUG=
R=glaznev@webrtc.org, pthatcher@webrtc.org

Committed:
https://chromium.googlesource.com/external/webrtc/+/c98006224210bb39c6427720c...
==========

[honghaiz3, 2016-08-01 16:27:48]

Committed patchset #3 (id:80001) manually as
c98006224210bb39c6427720cc62e5fbf628317b (presubmit successful).

[commit-bot: I haz the power, 2016-08-01 16:27:48]

Description was changed from

==========
Use a new method (android_setsocknetwork) to bind socket to network in Android M
and later.
The old method (setNetworkForSocket) is not supported in Android-N.

BUG=
R=glaznev@webrtc.org, pthatcher@webrtc.org

Committed:
https://chromium.googlesource.com/external/webrtc/+/c98006224210bb39c6427720c...
==========

to

==========
Use a new method (android_setsocknetwork) to bind socket to network in Android M
and later.
The old method (setNetworkForSocket) is not supported in Android-N.

BUG=
R=glaznev@webrtc.org, pthatcher@webrtc.org

Committed: https://crrev.com/c98006224210bb39c6427720cc62e5fbf628317b
Cr-Commit-Position: refs/heads/master@{#13591}
==========