Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(632)

Issue 2189133002: Print entire error object for capture session error handler (Closed)

Created:
4 years, 4 months ago by Chuck
Modified:
4 years, 4 months ago
Reviewers:
tkchin_webrtc
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com
Base URL:
https://chromium.googlesource.com/external/webrtc.git@master
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Print entire error object for capture session error handler NOTRY=True BUG= Committed: https://crrev.com/7a11ae3c7c2d3b04a24323efcc9864d92b637ded Cr-Commit-Position: refs/heads/master@{#13580}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M webrtc/sdk/objc/Framework/Classes/avfoundationvideocapturer.mm View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 13 (8 generated)
Chuck
4 years, 4 months ago (2016-07-28 20:30:33 UTC) #2
tkchin_webrtc
On 2016/07/28 20:30:33, Chuck wrote: lgtm
4 years, 4 months ago (2016-07-28 20:43:02 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2189133002/1
4 years, 4 months ago (2016-07-29 18:59:39 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 4 months ago (2016-07-29 19:03:56 UTC) #11
commit-bot: I haz the power
4 years, 4 months ago (2016-07-29 19:04:03 UTC) #13
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/7a11ae3c7c2d3b04a24323efcc9864d92b637ded
Cr-Commit-Position: refs/heads/master@{#13580}

Powered by Google App Engine
This is Rietveld 408576698