Chromium Code Reviews
|
|
Chromium Code Reviews|
Created:
4 years, 4 months ago by danilchap Modified:
4 years, 4 months ago Reviewers:
tommi, kwiberg-webrtc CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com, tommi Base URL:
https://chromium.googlesource.com/external/webrtc.git@master Target Ref:
refs/pending/heads/master Project:
webrtc Visibility:
Public. |
DescriptionFix CopyOnWriteBuffer::cdata to return const pointer
to prevent unexpected data modification.
Committed: https://crrev.com/8a0b1287cde0248843e649cc9e01f7d861649d34
Cr-Commit-Position: refs/heads/master@{#13583}
Patch Set 1 #
Created: 4 years, 4 months ago
Messages
Total messages: 17 (12 generated)
Description was changed from ========== CopyOnWriteBuffer::cdata returns const pointer ========== to ========== Fix CopyOnWriteBuffer::cdata to return const pointer ==========
Description was changed from ========== Fix CopyOnWriteBuffer::cdata to return const pointer ========== to ========== Fix CopyOnWriteBuffer::cdata to return const pointer to prevent data modification when it is not expected to be modified. ==========
Description was changed from ========== Fix CopyOnWriteBuffer::cdata to return const pointer to prevent data modification when it is not expected to be modified. ========== to ========== Fix CopyOnWriteBuffer::cdata to return const pointer to prevent unexpected data modification. ==========
danilchap@webrtc.org changed reviewers: + kwiberg@webrtc.org
tommi@webrtc.org changed reviewers: + tommi@webrtc.org
lgtm
The CQ bit was checked by tommi@webrtc.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: android_arm64_rel on master.tryserver.webrtc (JOB_FAILED, http://build.chromium.org/p/tryserver.webrtc/builders/android_arm64_rel/build...)
The CQ bit was checked by danilchap@webrtc.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...
Message was sent while issue was closed.
Description was changed from ========== Fix CopyOnWriteBuffer::cdata to return const pointer to prevent unexpected data modification. ========== to ========== Fix CopyOnWriteBuffer::cdata to return const pointer to prevent unexpected data modification. ==========
Message was sent while issue was closed.
Committed patchset #1 (id:1)
Message was sent while issue was closed.
Description was changed from ========== Fix CopyOnWriteBuffer::cdata to return const pointer to prevent unexpected data modification. ========== to ========== Fix CopyOnWriteBuffer::cdata to return const pointer to prevent unexpected data modification. Committed: https://crrev.com/8a0b1287cde0248843e649cc9e01f7d861649d34 Cr-Commit-Position: refs/heads/master@{#13583} ==========
Message was sent while issue was closed.
Patchset 1 (id:??) landed as https://crrev.com/8a0b1287cde0248843e649cc9e01f7d861649d34 Cr-Commit-Position: refs/heads/master@{#13583} |
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
