Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(25)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2188883002: Use 15fps for iPhone 4S (Closed)

Created:
4 years, 4 months ago by tkchin_webrtc
Modified:
4 years, 4 months ago
Reviewers:
magjed_webrtc, Chuck
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com
Base URL:
https://chromium.googlesource.com/external/webrtc.git@master
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Use 15fps for iPhone 4S NOTRY=True BUG= Committed: https://crrev.com/d7629105928b5062d604cc1dd19fa12c5f7386ff Cr-Commit-Position: refs/heads/master@{#13564}

Patch Set 1 #

Patch Set 2 : update build.gn #

Patch Set 3 : missed a file #

Patch Set 4 : guard ios only import. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+279 lines, -4 lines) Patch
M webrtc/sdk/BUILD.gn View 1 1 chunk +2 lines, -0 lines 0 comments Download
A webrtc/sdk/objc/Framework/Classes/UIDevice+RTCDevice.mm View 1 chunk +168 lines, -0 lines 0 comments Download
M webrtc/sdk/objc/Framework/Classes/avfoundationvideocapturer.mm View 1 2 3 7 chunks +42 lines, -4 lines 0 comments Download
A webrtc/sdk/objc/Framework/Headers/WebRTC/UIDevice+RTCDevice.h View 1 chunk +63 lines, -0 lines 0 comments Download
M webrtc/sdk/objc/Framework/Headers/WebRTC/WebRTC.h View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M webrtc/sdk/sdk.gyp View 2 chunks +3 lines, -0 lines 0 comments Download

Messages

Total messages: 21 (12 generated)
tkchin_webrtc
4 years, 4 months ago (2016-07-27 22:19:54 UTC) #3
magjed_webrtc
lgtm
4 years, 4 months ago (2016-07-28 10:36:11 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2188883002/40001
4 years, 4 months ago (2016-07-28 18:08:49 UTC) #7
commit-bot: I haz the power
Try jobs failed on following builders: mac_compile_dbg on master.tryserver.webrtc (JOB_FAILED, http://build.chromium.org/p/tryserver.webrtc/builders/mac_compile_dbg/builds/7074)
4 years, 4 months ago (2016-07-28 18:14:02 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2188883002/60001
4 years, 4 months ago (2016-07-28 18:31:47 UTC) #12
commit-bot: I haz the power
Try jobs failed on following builders: android_arm64_rel on master.tryserver.webrtc (JOB_FAILED, http://build.chromium.org/p/tryserver.webrtc/builders/android_arm64_rel/builds/9646)
4 years, 4 months ago (2016-07-28 21:49:50 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2188883002/60001
4 years, 4 months ago (2016-07-28 21:51:19 UTC) #17
commit-bot: I haz the power
Committed patchset #4 (id:60001)
4 years, 4 months ago (2016-07-28 21:53:01 UTC) #19
commit-bot: I haz the power
4 years, 4 months ago (2016-07-28 21:53:11 UTC) #21
Message was sent while issue was closed. 
Patchset 4 (id:??) landed as
https://crrev.com/d7629105928b5062d604cc1dd19fa12c5f7386ff
Cr-Commit-Position: refs/heads/master@{#13564}

Powered by Google App Engine
This is Rietveld 408576698