Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(421)

Issue 2187913002: Fixing invalid operator< implementation. (Closed)

Created:
4 years, 4 months ago by Taylor Brandstetter
Modified:
4 years, 4 months ago
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com
Base URL:
https://chromium.googlesource.com/external/webrtc.git@master
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Fixing invalid operator< implementation. It was possible that "A < B" and "B < A" both evaluated to true. This manifested as an assert on Windows, and a memory leak on Linux. Note that the concept of "less than" is meaningless for this object. The operator is only needed so the object can be used as a key in an std::map. BUG=webrtc:6068 R=honghaiz@webrtc.org, kjellander@webrtc.org, skvlad@webrtc.org Committed: https://crrev.com/734262c765dbd13b34da1d016c82c7d3d2c4c50c Cr-Commit-Position: refs/heads/master@{#13598}

Patch Set 1 #

Total comments: 4

Patch Set 2 : Using std::tie, added unit test. #

Patch Set 3 : Fixing comment. #

Patch Set 4 : . #

Unified diffs Side-by-side diffs Delta from patch set Stats (+74 lines, -10 lines) Patch
M webrtc/BUILD.gn View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M webrtc/p2p/base/turnserver.cc View 1 2 chunks +3 lines, -1 line 0 comments Download
A webrtc/p2p/base/turnserver_unittest.cc View 1 2 1 chunk +68 lines, -0 lines 0 comments Download
M webrtc/p2p/client/basicportallocator_unittest.cc View 1 2 1 chunk +1 line, -9 lines 0 comments Download
M webrtc/webrtc_tests.gypi View 1 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 20 (7 generated)
Taylor Brandstetter
PTAL
4 years, 4 months ago (2016-07-27 17:53:36 UTC) #2
skvlad
lgtm Good catch!
4 years, 4 months ago (2016-07-27 18:00:56 UTC) #3
honghaiz3
https://codereview.webrtc.org/2187913002/diff/1/webrtc/p2p/base/turnserver.cc File webrtc/p2p/base/turnserver.cc (right): https://codereview.webrtc.org/2187913002/diff/1/webrtc/p2p/base/turnserver.cc#newcode547 webrtc/p2p/base/turnserver.cc:547: if (src_ != c.src_) { Probably this is a ...
4 years, 4 months ago (2016-07-27 18:38:13 UTC) #4
Taylor Brandstetter
https://codereview.webrtc.org/2187913002/diff/1/webrtc/p2p/base/turnserver.cc File webrtc/p2p/base/turnserver.cc (right): https://codereview.webrtc.org/2187913002/diff/1/webrtc/p2p/base/turnserver.cc#newcode547 webrtc/p2p/base/turnserver.cc:547: if (src_ != c.src_) { On 2016/07/27 18:38:13, honghaiz3 ...
4 years, 4 months ago (2016-07-28 22:42:08 UTC) #5
honghaiz3
Do you forget to upload the change?
4 years, 4 months ago (2016-07-28 22:54:45 UTC) #6
Taylor Brandstetter
On 2016/07/28 22:54:45, honghaiz3 wrote: > Do you forget to upload the change? Uploaded to ...
4 years, 4 months ago (2016-07-29 00:59:24 UTC) #7
honghaiz3
lgtm Thanks for fixing this!
4 years, 4 months ago (2016-07-29 15:40:55 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2187913002/20001
4 years, 4 months ago (2016-08-01 18:48:16 UTC) #11
commit-bot: I haz the power
Try jobs failed on following builders: presubmit on master.tryserver.webrtc (JOB_FAILED, http://build.chromium.org/p/tryserver.webrtc/builders/presubmit/builds/7115)
4 years, 4 months ago (2016-08-01 18:58:48 UTC) #13
Taylor Brandstetter
kjellander: Need your approval for change to BUILD.gn.
4 years, 4 months ago (2016-08-01 20:02:54 UTC) #15
kjellander_webrtc
*.gn,*.gyp: lgtm
4 years, 4 months ago (2016-08-01 20:10:36 UTC) #16
kjellander_webrtc
*.gn,*.gyp: lgtm
4 years, 4 months ago (2016-08-01 20:10:37 UTC) #17
Taylor Brandstetter
4 years, 4 months ago (2016-08-01 23:37:27 UTC) #19
Message was sent while issue was closed.
Committed patchset #4 (id:60001) manually as
734262c765dbd13b34da1d016c82c7d3d2c4c50c (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698