Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(156)

Unified Diff: webrtc/media/engine/webrtcvideoengine2.cc

Issue 2185953002: Add decoder-specific settings with proper lifetime. (Closed) Base URL: https://chromium.googlesource.com/external/webrtc.git@master
Patch Set: fix unit test Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: webrtc/media/engine/webrtcvideoengine2.cc
diff --git a/webrtc/media/engine/webrtcvideoengine2.cc b/webrtc/media/engine/webrtcvideoengine2.cc
index 5da8e33e1e0d784ab4e5b879a1b19cb5cc2fbeb8..d2e7e250993edacf9832dd06f1347dd07eca39ef 100644
--- a/webrtc/media/engine/webrtcvideoengine2.cc
+++ b/webrtc/media/engine/webrtcvideoengine2.cc
@@ -2331,6 +2331,20 @@ WebRtcVideoChannel2::WebRtcVideoReceiveStream::CreateOrReuseVideoDecoder(
webrtc::kVideoCodecUnknown, false);
}
+void ConfigureDecoderSpecifics(webrtc::VideoReceiveStream::Decoder* decoder,
+ const cricket::VideoCodec& recv_video_codec) {
+ if (recv_video_codec.name.compare("H264") == 0) {
+ auto it = recv_video_codec.params.find("sprop-parameter-sets");
+ if (it != recv_video_codec.params.end()) {
+ decoder->decoder_specific.h264_extra_settings =
+ rtc::Optional<webrtc::VideoDecoderH264Settings>(
+ webrtc::VideoDecoderH264Settings());
+ decoder->decoder_specific.h264_extra_settings->sprop_parameter_sets =
+ it->second;
+ }
+ }
+}
+
void WebRtcVideoChannel2::WebRtcVideoReceiveStream::ConfigureCodecs(
const std::vector<VideoCodecSettings>& recv_codecs,
std::vector<AllocatedDecoder>* old_decoders) {
@@ -2346,6 +2360,7 @@ void WebRtcVideoChannel2::WebRtcVideoReceiveStream::ConfigureCodecs(
decoder.decoder = allocated_decoder.decoder;
decoder.payload_type = recv_codecs[i].codec.id;
decoder.payload_name = recv_codecs[i].codec.name;
+ ConfigureDecoderSpecifics(&decoder, recv_codecs[i].codec);
config_.decoders.push_back(decoder);
}

Powered by Google App Engine
This is Rietveld 408576698