Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(301)

Unified Diff: webrtc/config.h

Issue 2185953002: Add decoder-specific settings with proper lifetime. (Closed) Base URL: https://chromium.googlesource.com/external/webrtc.git@master
Patch Set: Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | webrtc/config.cc » ('j') | webrtc/media/engine/webrtcvideoengine2.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: webrtc/config.h
diff --git a/webrtc/config.h b/webrtc/config.h
index b2dfe2d272642fa5b8f73bd4a0e75b4a3c4925d1..6371b4f42f64292a9988a0896cc30f9611501fb0 100644
--- a/webrtc/config.h
+++ b/webrtc/config.h
@@ -16,6 +16,9 @@
#include <string>
#include <vector>
+#include "webrtc/base/optional.h"
+#include "webrtc/base/refcount.h"
+#include "webrtc/base/scoped_ref_ptr.h"
sprang_webrtc 2016/07/27 08:37:25 Not sure what the current policy is regarding impo
#include "webrtc/common.h"
#include "webrtc/common_types.h"
#include "webrtc/typedefs.h"
@@ -146,6 +149,20 @@ struct VideoEncoderConfig {
bool expect_encode_from_texture;
};
+struct VideoDecoderH264extraSettings {
+ std::string spropParameterSets;
+};
+
+// These are reference counted to permit copying VideoDecoderConfig and be
+// kept alive until all decoder_specific_settings go out of scope.
+//
+class DecoderSpecificSettings : public rtc::RefCountInterface {
+ public:
+ virtual ~DecoderSpecificSettings() {}
+ rtc::Optional<VideoDecoderH264extraSettings> h264_extra_settings;
+ // vp8_extra_settings, and vp9_extra_settings will be added when required
+};
sprang_webrtc 2016/07/27 08:37:25 If we're using an Optional for each codec, I'm not
+
// Controls the capacity of the packet buffer in NetEq. The capacity is the
// maximum number of packets that the buffer can contain. If the limit is
// exceeded, the buffer will be flushed. The capacity does not affect the actual
« no previous file with comments | « no previous file | webrtc/config.cc » ('j') | webrtc/media/engine/webrtcvideoengine2.cc » ('J')

Powered by Google App Engine
This is Rietveld 408576698