Android Camera2Enumerator: Remove CameraAccessException to avoid VerifyError

Android Camera2Enumerator: Remove CameraAccessException to avoid VerifyError

Apparently, a class will fail with VerifyError if it contains catch
statements with an Exception from a newer API, even if the code is never
executed. This happens only on Android versions before 4.4.2 and is a
bug. See https://code.google.com/p/android/issues/detail?id=209129 for
more info.

BUG=b/30376736

Committed: https://crrev.com/43e15bb9f01476114cf85be8a47922df2fd7dcf5
Cr-Commit-Position: refs/heads/master@{#13542}

[magjed_webrtc, 2016-07-27 12:28:04]

Description was changed from

==========
Android Camera2Enumerator: Remove CameraAccessException to avoid VerifyError

Apparently, a class will fail with VerifyError if it contains catch
statements with an Exception from a newer API, even if the code is never
executed. This happens only on Android versions before 4.4.2 and is a
bug. See https://code.google.com/p/android/issues/detail?id=209129 for
more info.

BUG=b/30376736
==========

to

==========
Android Camera2Enumerator: Remove CameraAccessException to avoid VerifyError

Apparently, a class will fail with VerifyError if it contains catch
statements with an Exception from a newer API, even if the code is never
executed. This happens only on Android versions before 4.4.2 and is a
bug. See https://code.google.com/p/android/issues/detail?id=209129 for
more info.

BUG=b/30376736
==========

[magjed_webrtc, 2016-07-27 12:28:04]

magjed@webrtc.org changed reviewers:
+ sakal@webrtc.org

[magjed_webrtc, 2016-07-27 12:28:24]

sami - please take a look.

[sakal, 2016-07-27 12:32:34]

https://codereview.webrtc.org/2185833003/diff/1/webrtc/api/android/java/src/o...
File webrtc/api/android/java/src/org/webrtc/Camera2Enumerator.java (right):

https://codereview.webrtc.org/2185833003/diff/1/webrtc/api/android/java/src/o...
webrtc/api/android/java/src/org/webrtc/Camera2Enumerator.java:58: } catch (/*
CameraAccessException */ Exception e) {
Can we catch AndroidException instead?

https://codereview.webrtc.org/2185833003/diff/1/webrtc/api/android/java/src/o...
webrtc/api/android/java/src/org/webrtc/Camera2Enumerator.java:96: } catch (/*
CameraAccessException */ Exception e) {
ditto

[magjed_webrtc, 2016-07-27 13:05:58]

https://codereview.webrtc.org/2185833003/diff/1/webrtc/api/android/java/src/o...
File webrtc/api/android/java/src/org/webrtc/Camera2Enumerator.java (right):

https://codereview.webrtc.org/2185833003/diff/1/webrtc/api/android/java/src/o...
webrtc/api/android/java/src/org/webrtc/Camera2Enumerator.java:58: } catch (/*
CameraAccessException */ Exception e) {
On 2016/07/27 12:32:34, sakal wrote:
> Can we catch AndroidException instead?

Done.

https://codereview.webrtc.org/2185833003/diff/1/webrtc/api/android/java/src/o...
webrtc/api/android/java/src/org/webrtc/Camera2Enumerator.java:96: } catch (/*
CameraAccessException */ Exception e) {
On 2016/07/27 12:32:34, sakal wrote:
> ditto

Done.

[sakal, 2016-07-27 13:09:00]

lgtm

[magjed_webrtc, 2016-07-27 14:46:10]

The CQ bit was checked by magjed@webrtc.org

[commit-bot: I haz the power, 2016-07-27 14:46:14]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...

[commit-bot: I haz the power, 2016-07-27 15:25:12]

Description was changed from

==========
Android Camera2Enumerator: Remove CameraAccessException to avoid VerifyError

Apparently, a class will fail with VerifyError if it contains catch
statements with an Exception from a newer API, even if the code is never
executed. This happens only on Android versions before 4.4.2 and is a
bug. See https://code.google.com/p/android/issues/detail?id=209129 for
more info.

BUG=b/30376736
==========

to

==========
Android Camera2Enumerator: Remove CameraAccessException to avoid VerifyError

Apparently, a class will fail with VerifyError if it contains catch
statements with an Exception from a newer API, even if the code is never
executed. This happens only on Android versions before 4.4.2 and is a
bug. See https://code.google.com/p/android/issues/detail?id=209129 for
more info.

BUG=b/30376736
==========

[commit-bot: I haz the power, 2016-07-27 15:25:16]

Description was changed from

==========
Android Camera2Enumerator: Remove CameraAccessException to avoid VerifyError

Apparently, a class will fail with VerifyError if it contains catch
statements with an Exception from a newer API, even if the code is never
executed. This happens only on Android versions before 4.4.2 and is a
bug. See https://code.google.com/p/android/issues/detail?id=209129 for
more info.

BUG=b/30376736
==========

to

==========
Android Camera2Enumerator: Remove CameraAccessException to avoid VerifyError

Apparently, a class will fail with VerifyError if it contains catch
statements with an Exception from a newer API, even if the code is never
executed. This happens only on Android versions before 4.4.2 and is a
bug. See https://code.google.com/p/android/issues/detail?id=209129 for
more info.

BUG=b/30376736

Committed: https://crrev.com/43e15bb9f01476114cf85be8a47922df2fd7dcf5
Cr-Commit-Position: refs/heads/master@{#13542}
==========

[commit-bot: I haz the power, 2016-07-27 15:25:17]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2016-07-27 15:25:17]

Patchset 3 (id:??) landed as
https://crrev.com/43e15bb9f01476114cf85be8a47922df2fd7dcf5
Cr-Commit-Position: refs/heads/master@{#13542}