Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(56)

Issue 2185673002: Disable some Opus tests pending an update (Closed)

Created:
4 years, 4 months ago by flim-webrtc
Modified:
4 years, 4 months ago
Reviewers:
minyue-webrtc
CC:
webrtc-reviews_webrtc.org, kwiberg-webrtc, tlegrand-webrtc, tterriberry_mozilla.com, audio-team_agora.io, hlundin-webrtc, peah-webrtc, minyue-webrtc
Base URL:
https://chromium.googlesource.com/external/webrtc.git@master
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Disable some Opus tests pending an update These tests will be reenabled and fixed after Opus 1.1.3 has landed in Chromium and is rolled into WebRTC. BUG= Committed: https://crrev.com/1cd46643d70c7d94fd42ef1d5346ac6e9f48dd5d Cr-Commit-Position: refs/heads/master@{#13534}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -4 lines) Patch
M webrtc/modules/audio_coding/acm2/audio_coding_module_unittest_oldapi.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M webrtc/modules/audio_coding/neteq/neteq_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 11 (5 generated)
flim-webrtc
4 years, 4 months ago (2016-07-26 15:01:43 UTC) #2
minyue-webrtc
lgtm
4 years, 4 months ago (2016-07-26 15:20:16 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2185673002/1
4 years, 4 months ago (2016-07-26 15:21:27 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2185673002/1
4 years, 4 months ago (2016-07-26 15:21:55 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 4 months ago (2016-07-26 16:01:42 UTC) #9
commit-bot: I haz the power
4 years, 4 months ago (2016-07-26 16:01:53 UTC) #11
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/1cd46643d70c7d94fd42ef1d5346ac6e9f48dd5d
Cr-Commit-Position: refs/heads/master@{#13534}

Powered by Google App Engine
This is Rietveld 408576698