Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(437)

Issue 2184223003: Fix an UI bug in AppRTC Demo where disable hardware AGC/NS summary was not getting updated. (Closed)

Created:
4 years, 4 months ago by sakal
Modified:
4 years, 4 months ago
Reviewers:
magjed_webrtc
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com, henrika_webrtc
Base URL:
https://chromium.googlesource.com/external/webrtc.git@master
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Fix an UI bug in AppRTC Demo where disable hardware AGC/NS summary was not getting updated. In Android AppRTC Demo, there was a bug where toggling disable hardware AGC/NS would not be reflected into the summary of those settings. This change fixes this issue. Committed: https://crrev.com/178ae905c88d31078ee40dc5c77abd20ded16253 Cr-Commit-Position: refs/heads/master@{#13551}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -0 lines) Patch
M webrtc/examples/androidapp/src/org/appspot/apprtc/SettingsActivity.java View 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 11 (6 generated)
sakal
Magnus, PTAL.
4 years, 4 months ago (2016-07-28 07:14:30 UTC) #4
magjed_webrtc
lgtm
4 years, 4 months ago (2016-07-28 10:28:05 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2184223003/1
4 years, 4 months ago (2016-07-28 10:28:37 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 4 months ago (2016-07-28 12:55:37 UTC) #9
commit-bot: I haz the power
4 years, 4 months ago (2016-07-28 12:55:50 UTC) #11
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/178ae905c88d31078ee40dc5c77abd20ded16253
Cr-Commit-Position: refs/heads/master@{#13551}

Powered by Google App Engine
This is Rietveld 408576698