Un-flaking TestSrtpError by using a fake clock.

Un-flaking TestSrtpError by using a fake clock.

This test verifies that SRTP errors are only signaled if a specific
amount of time has passed, and was using ProcessMessages(time) to
wait for an amount of time. But ProcessMessages may sometimes wait
for longer than the requested time (especially on TSAN bot, etc.).

BUG=webrtc:4690
R=tommi@webrtc.org

Committed: https://chromium.googlesource.com/external/webrtc/+/88532898db9f01bedc3b2caae8b2cf4e7bea8dcb

[Taylor Brandstetter, 2016-07-28 21:22:42]

deadbeef@webrtc.org changed reviewers:
+ tommi@webrtc.org

[Taylor Brandstetter, 2016-07-28 21:22:43]

PTAL. This is a flaky test I noticed while sheriff this week, and I noticed you
reviewed the last attempt to un-flake it.

[tommi, 2016-07-29 04:45:29]

The CQ bit was checked by tommi@webrtc.org

[tommi, 2016-07-29 04:45:32]

lgtm

[commit-bot: I haz the power, 2016-07-29 04:45:41]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...

[commit-bot: I haz the power, 2016-07-29 05:01:21]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-07-29 05:01:21]

Try jobs failed on following builders:
  android_arm64_rel on master.tryserver.webrtc (JOB_FAILED,
http://build.chromium.org/p/tryserver.webrtc/builders/android_arm64_rel/build...)

[Taylor Brandstetter, 2016-08-01 18:07:08]

The CQ bit was checked by deadbeef@webrtc.org

[commit-bot: I haz the power, 2016-08-01 18:07:13]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...

[commit-bot: I haz the power, 2016-08-01 20:07:51]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-01 20:07:51]

Try jobs failed on following builders:
  android_arm64_rel on master.tryserver.webrtc (JOB_TIMED_OUT, no build URL)

[commit-bot: I haz the power, 2016-08-01 21:17:45]

Description was changed from

==========
Un-flaking TestSrtpError by using a fake clock.

This test verifies that SRTP errors are only signaled if a specific
amount of time has passed, and was using ProcessMessages(time) to
wait for an amount of time. But ProcessMessages may sometimes wait
for longer than the requested time (especially on TSAN bot, etc.).

BUG=webrtc:4690
==========

to

==========
Un-flaking TestSrtpError by using a fake clock.

This test verifies that SRTP errors are only signaled if a specific
amount of time has passed, and was using ProcessMessages(time) to
wait for an amount of time. But ProcessMessages may sometimes wait
for longer than the requested time (especially on TSAN bot, etc.).

BUG=webrtc:4690
R=tommi@webrtc.org

Committed: https://crrev.com/88532898db9f01bedc3b2caae8b2cf4e7bea8dcb
Cr-Commit-Position: refs/heads/master@{#13597}
==========

[commit-bot: I haz the power, 2016-08-01 21:17:46]

Patchset 1 (id:??) landed as
https://crrev.com/88532898db9f01bedc3b2caae8b2cf4e7bea8dcb
Cr-Commit-Position: refs/heads/master@{#13597}

[Taylor Brandstetter, 2016-08-01 21:17:48]

Description was changed from

==========
Un-flaking TestSrtpError by using a fake clock.

This test verifies that SRTP errors are only signaled if a specific
amount of time has passed, and was using ProcessMessages(time) to
wait for an amount of time. But ProcessMessages may sometimes wait
for longer than the requested time (especially on TSAN bot, etc.).

BUG=webrtc:4690
R=tommi@webrtc.org

Committed: https://crrev.com/88532898db9f01bedc3b2caae8b2cf4e7bea8dcb
Cr-Commit-Position: refs/heads/master@{#13597}
==========

to

==========
Un-flaking TestSrtpError by using a fake clock.

This test verifies that SRTP errors are only signaled if a specific
amount of time has passed, and was using ProcessMessages(time) to
wait for an amount of time. But ProcessMessages may sometimes wait
for longer than the requested time (especially on TSAN bot, etc.).

BUG=webrtc:4690
R=tommi@webrtc.org

Committed:
https://chromium.googlesource.com/external/webrtc/+/88532898db9f01bedc3b2caae...
==========

[Taylor Brandstetter, 2016-08-01 21:17:52]

Committed patchset #1 (id:1) manually as
88532898db9f01bedc3b2caae8b2cf4e7bea8dcb (presubmit successful).