Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2184043002:
Creating GN version of xmllite_xmpp_unittests (Closed)
|
Created:
4 years, 4 months ago by charujain Modified:
4 years, 4 months ago CC:
webrtc-reviews_webrtc.org, yujie_mao (webrtc), kwiberg-webrtc, hlundin-webrtc, tlegrand-webrtc, tterriberry_mozilla.com, audio-team_agora.io, qiang.lu, niklas.enbom, peah-webrtc, minyue-webrtc Base URL:
https://chromium.googlesource.com/external/webrtc.git@master Target Ref:
refs/pending/heads/master Project:
webrtc Visibility:
Public. |
DescriptionCreating GN version of xmllite_xmpp_unittests
NOTRY=True
BUG=webrtc:6043
Committed: https://crrev.com/604fc114fb0e682442e36c365e9192ff5a857a45
Cr-Commit-Position: refs/heads/master@{#13633}
Patch Set 1 #Patch Set 2 : Creating GN version of xmllite_xmpp_unittests #
Messages
Total messages: 28 (14 generated)
Description was changed from ========== Creating GN version of xmllite_xmpp_unittests BUG=webrtc:6043 Creating GN version of audio_decoder_unittests for linux tool chain Formatting Adding gn conversion for audio_decoder_unittests for android and ios also for Neteq files Formatted Creating GN version of audio_decoder_unittests for linux tool chain BUG=webrtc:6036 ========== to ========== Creating GN version of xmllite_xmpp_unittests BUG=webrtc:6043 ==========
charujain@webrtc.org changed reviewers: + phoglund@webrtc.org
lgtm
The CQ bit was checked by charujain@webrtc.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: presubmit on master.tryserver.webrtc (JOB_FAILED, http://build.chromium.org/p/tryserver.webrtc/builders/presubmit/builds/7048)
LGTM
The CQ bit was checked by charujain@webrtc.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: android_arm64_rel on master.tryserver.webrtc (JOB_FAILED, http://build.chromium.org/p/tryserver.webrtc/builders/android_arm64_rel/build...)
The CQ bit was checked by charujain@webrtc.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: android_arm64_rel on master.tryserver.webrtc (JOB_TIMED_OUT, no build URL)
The CQ bit was checked by charujain@webrtc.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: android_arm64_rel on master.tryserver.webrtc (JOB_FAILED, http://build.chromium.org/p/tryserver.webrtc/builders/android_arm64_rel/build...)
On 2016/08/04 07:56:15, commit-bot: I haz the power wrote: > Try jobs failed on following builders: > android_arm64_rel on master.tryserver.webrtc (JOB_FAILED, > http://build.chromium.org/p/tryserver.webrtc/builders/android_arm64_rel/build...) For patches like this, that only affects GN, it's useful to just add NOTRY=True to the CL description and trigger the *_gn_* bots in tryserver.webrtc manually. If they're green - feel free to submit (and we can see that they are).
Description was changed from ========== Creating GN version of xmllite_xmpp_unittests BUG=webrtc:6043 ========== to ========== Creating GN version of xmllite_xmpp_unittests NOTRY=True BUG=webrtc:6043 ==========
The CQ bit was checked by charujain@webrtc.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...
Message was sent while issue was closed.
Description was changed from ========== Creating GN version of xmllite_xmpp_unittests NOTRY=True BUG=webrtc:6043 ========== to ========== Creating GN version of xmllite_xmpp_unittests NOTRY=True BUG=webrtc:6043 ==========
Message was sent while issue was closed.
Committed patchset #2 (id:20001)
Message was sent while issue was closed.
Description was changed from ========== Creating GN version of xmllite_xmpp_unittests NOTRY=True BUG=webrtc:6043 ========== to ========== Creating GN version of xmllite_xmpp_unittests NOTRY=True BUG=webrtc:6043 Committed: https://crrev.com/604fc114fb0e682442e36c365e9192ff5a857a45 Cr-Commit-Position: refs/heads/master@{#13633} ==========
Message was sent while issue was closed.
Patchset 2 (id:??) landed as https://crrev.com/604fc114fb0e682442e36c365e9192ff5a857a45 Cr-Commit-Position: refs/heads/master@{#13633} |
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
