Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(63)

Issue 2184013003: Delay destroying a port if new connections are created and destroyed. (Closed)

Created:
4 years, 4 months ago by honghaiz3
Modified:
4 years, 4 months ago
Reviewers:
Zhi Huang, pthatcher1
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com
Base URL:
https://chromium.googlesource.com/external/webrtc@master
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Delay destroying a port if new connections are created and destroyed. If all connections on a port is destroyed, it will schedule an event to check if it is dead after a timeout. Previously if a new connection is created but destroyed before the event is fired, it will destroy the port. With this change, we will not destoy it until it times out again after the last created connection is destroyed. BUG= R=pthatcher@webrtc.org, zhihuang@webrtc.org Committed: https://chromium.googlesource.com/external/webrtc/+/b5db1ec0e5760e370c2afe7e4171a9128039ae53

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+33 lines, -15 lines) Patch
M webrtc/p2p/base/port.h View 3 chunks +3 lines, -7 lines 0 comments Download
M webrtc/p2p/base/port.cc View 2 chunks +11 lines, -4 lines 0 comments Download
M webrtc/p2p/base/port_unittest.cc View 2 chunks +19 lines, -4 lines 0 comments Download

Messages

Total messages: 10 (4 generated)
honghaiz3
4 years, 4 months ago (2016-07-27 22:20:28 UTC) #2
pthatcher1
lgtm
4 years, 4 months ago (2016-07-28 17:59:44 UTC) #3
Zhi Huang
On 2016/07/27 22:20:28, honghaiz3 wrote: lgtm
4 years, 4 months ago (2016-07-28 18:27:02 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2184013003/1
4 years, 4 months ago (2016-07-28 19:20:09 UTC) #6
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/b5db1ec0e5760e370c2afe7e4171a9128039ae53 Cr-Commit-Position: refs/heads/master@{#13563}
4 years, 4 months ago (2016-07-28 20:23:25 UTC) #8
honghaiz3
4 years, 4 months ago (2016-07-28 20:23:27 UTC) #10
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
b5db1ec0e5760e370c2afe7e4171a9128039ae53 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698