Creating GN version of audio_decoder_unittests for linux tool chain

Creating GN version of audio_decoder_unittests for linux tool chain

BUG=webrtc:6036

[charujain, 2016-07-26 11:46:24]

charujain@webrtc.org changed reviewers:
+ phoglund@webrtc.org

[phoglund, 2016-07-26 14:17:46]

Fix the CL subject and description. Also, let me know when the target builds
right and I'll review.

[charujain, 2016-07-27 07:40:41]

Description was changed from

==========
Formatted


Creating GN version of audio_decoder_unittests for linux tool chain

BUG=webrtc:6036
==========

to

==========
Creating GN version of audio_decoder_unittests for linux tool chain

BUG=webrtc:6036
==========

[phoglund, 2016-07-27 08:23:52]

https://codereview.webrtc.org/2182063002/diff/40001/webrtc/modules/audio_codi...
File webrtc/modules/audio_coding/BUILD.gn (right):

https://codereview.webrtc.org/2182063002/diff/40001/webrtc/modules/audio_codi...
webrtc/modules/audio_coding/BUILD.gn:960: ":neteq",
I don't see this one in the deps list in the gyp file. Also 'g722' and 'ilbc'
are in therem but you're missing them. I think the deps list should be the same
for GN. Maybe it's better to try and remove them from the gyp list, since they
appear to be not necessary?

[charujain, 2016-07-27 08:32:13]

https://codereview.webrtc.org/2182063002/diff/40001/webrtc/modules/audio_codi...
File webrtc/modules/audio_coding/BUILD.gn (right):

https://codereview.webrtc.org/2182063002/diff/40001/webrtc/modules/audio_codi...
webrtc/modules/audio_coding/BUILD.gn:960: ":neteq",
On 2016/07/27 08:23:52, phoglund wrote:
> I don't see this one in the deps list in the gyp file. Also 'g722' and 'ilbc'
> are in therem but you're missing them. I think the deps list should be the
same
> for GN. Maybe it's better to try and remove them from the gyp list, since they
> appear to be not necessary?

If you look at "audio_coding_deps" defined at top of gn file you will find g722
and ilbc defined there.

[phoglund, 2016-07-27 08:45:48]

lgtm

https://codereview.webrtc.org/2182063002/diff/40001/webrtc/modules/audio_codi...
File webrtc/modules/audio_coding/BUILD.gn (right):

https://codereview.webrtc.org/2182063002/diff/40001/webrtc/modules/audio_codi...
webrtc/modules/audio_coding/BUILD.gn:960: ":neteq",
On 2016/07/27 08:32:13, charujain wrote:
> On 2016/07/27 08:23:52, phoglund wrote:
> > I don't see this one in the deps list in the gyp file. Also 'g722' and
'ilbc'
> > are in therem but you're missing them. I think the deps list should be the
> same
> > for GN. Maybe it's better to try and remove them from the gyp list, since
they
> > appear to be not necessary?
> 
> If you look at "audio_coding_deps" defined at top of gn file you will find
g722
> and ilbc defined there. 
> 
> 
> 

You are right, they should be added by the logic there since build with mozilla
will be false (and it makes sense to just add ilbc if we're actually building
ilbc).

[phoglund, 2016-07-27 08:46:45]

phoglund@webrtc.org changed reviewers:
+ henrika@webrtc.org

[phoglund, 2016-07-27 08:46:46]

henrika, please rubberstamp (I don't have OWNERS here)

[henrika_webrtc, 2016-07-27 08:48:10]

LGTM

[charujain, 2016-07-27 09:11:00]

The CQ bit was checked by charujain@webrtc.org

[commit-bot: I haz the power, 2016-07-27 09:11:11]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...

[commit-bot: I haz the power, 2016-07-27 09:13:23]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-07-27 09:13:24]

Try jobs failed on following builders:
  android_gn_dbg on master.tryserver.webrtc (JOB_FAILED,
http://build.chromium.org/p/tryserver.webrtc/builders/android_gn_dbg/builds/1...)
  android_gn_rel on master.tryserver.webrtc (JOB_FAILED,
http://build.chromium.org/p/tryserver.webrtc/builders/android_gn_rel/builds/1...)