Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(914)

Issue 2181933002: Don't crash if createDataChannel fails. (Closed)

Created:
4 years, 4 months ago by Taylor Brandstetter
Modified:
4 years, 4 months ago
Reviewers:
AlexG
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com
Base URL:
https://chromium.googlesource.com/external/webrtc.git@master
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Don't crash if createDataChannel fails. It can fail in some real circumstances, such as when IDs are exhausted or you explicitly try to create one with an already-used ID. Committed: https://crrev.com/5f5504f218080e83e1eb64ce139535e5678ede16 Cr-Commit-Position: refs/heads/master@{#13535}

Patch Set 1 #

Total comments: 2

Patch Set 2 : Change warning level to error. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -1 line) Patch
M webrtc/api/android/jni/peerconnection_jni.cc View 1 1 chunk +4 lines, -1 line 0 comments Download

Messages

Total messages: 10 (4 generated)
Taylor Brandstetter
4 years, 4 months ago (2016-07-26 03:41:54 UTC) #2
AlexG
lgtm https://codereview.webrtc.org/2181933002/diff/1/webrtc/api/android/jni/peerconnection_jni.cc File webrtc/api/android/jni/peerconnection_jni.cc (right): https://codereview.webrtc.org/2181933002/diff/1/webrtc/api/android/jni/peerconnection_jni.cc#newcode1730 webrtc/api/android/jni/peerconnection_jni.cc:1730: LOG(LS_WARNING) << "Failed to create DataChannel"; LS_ERROR?
4 years, 4 months ago (2016-07-26 05:16:22 UTC) #3
Taylor Brandstetter
https://codereview.webrtc.org/2181933002/diff/1/webrtc/api/android/jni/peerconnection_jni.cc File webrtc/api/android/jni/peerconnection_jni.cc (right): https://codereview.webrtc.org/2181933002/diff/1/webrtc/api/android/jni/peerconnection_jni.cc#newcode1730 webrtc/api/android/jni/peerconnection_jni.cc:1730: LOG(LS_WARNING) << "Failed to create DataChannel"; On 2016/07/26 05:16:21, ...
4 years, 4 months ago (2016-07-26 16:51:34 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2181933002/20001
4 years, 4 months ago (2016-07-26 16:51:58 UTC) #7
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 4 months ago (2016-07-26 17:31:13 UTC) #8
commit-bot: I haz the power
4 years, 4 months ago (2016-07-26 17:31:20 UTC) #10
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/5f5504f218080e83e1eb64ce139535e5678ede16
Cr-Commit-Position: refs/heads/master@{#13535}

Powered by Google App Engine
This is Rietveld 408576698