Filter to formats that match device sensor array aspect ratio on pre-LMR1 devices.

Filter to formats that match device sensor array aspect ratio on pre-LMR1 devices offering only legacy camera2 support.

There is a bug on pre LMR1 devices that only support legacy
implementation of camera2 API where aspect ratio of the camera is
incorrect if the output format doesn't match the aspect ratio of the
sensor array. On these devices, we want to disable the output formats that
have different aspect ratio.

Committed: https://crrev.com/f22d3c48fa14502cd4c8e0ffc4c1eae4d7116b6f
Cr-Commit-Position: refs/heads/master@{#13538}

[sakal, 2016-07-26 11:15:33]

Description was changed from

==========
Filter to formats that match device sensor array aspect on pre LMR1 devices.

There is a bug on pre LMR1 devices that only support legacy
implementation of camera2 API where aspect ratio of the camera is
incorrect if the output format doesn't match the aspect ratio of the
sensor array. On these devices, we want to disable the output formats that
have different aspect ratio.
==========

to

==========
Filter to formats that match device sensor array aspect ratio on pre LMR1
devices offering only legacy camera2 support.

There is a bug on pre LMR1 devices that only support legacy
implementation of camera2 API where aspect ratio of the camera is
incorrect if the output format doesn't match the aspect ratio of the
sensor array. On these devices, we want to disable the output formats that
have different aspect ratio.
==========

[sakal, 2016-07-26 11:38:48]

sakal@webrtc.org changed reviewers:
+ magjed@webrtc.org

[sakal, 2016-07-26 11:38:49]

Magnus, PTAL.

[sakal, 2016-07-26 11:38:51]

Magnus, PTAL.

[sakal, 2016-07-26 11:39:07]

Description was changed from

==========
Filter to formats that match device sensor array aspect ratio on pre LMR1
devices offering only legacy camera2 support.

There is a bug on pre LMR1 devices that only support legacy
implementation of camera2 API where aspect ratio of the camera is
incorrect if the output format doesn't match the aspect ratio of the
sensor array. On these devices, we want to disable the output formats that
have different aspect ratio.
==========

to

==========
Filter to formats that match device sensor array aspect ratio on pre-LMR1
devices offering only legacy camera2 support.

There is a bug on pre LMR1 devices that only support legacy
implementation of camera2 API where aspect ratio of the camera is
incorrect if the output format doesn't match the aspect ratio of the
sensor array. On these devices, we want to disable the output formats that
have different aspect ratio.
==========

[magjed_webrtc, 2016-07-26 13:38:15]

https://codereview.webrtc.org/2181803003/diff/1/webrtc/api/android/java/src/o...
File webrtc/api/android/java/src/org/webrtc/Camera2Enumerator.java (right):

https://codereview.webrtc.org/2181803003/diff/1/webrtc/api/android/java/src/o...
webrtc/api/android/java/src/org/webrtc/Camera2Enumerator.java:40: private final
static double MIN_ASPECT_RATIO_RATIO = 0.99;
do integer comparison instead, i.e. instead of 'width1 / height1 == width2 /
height2' do 'width1 * height2 == width2 * height1'.

https://codereview.webrtc.org/2181803003/diff/1/webrtc/api/android/java/src/o...
webrtc/api/android/java/src/org/webrtc/Camera2Enumerator.java:105: 
nit: remove this extra line

[sakal, 2016-07-26 13:54:55]

https://codereview.webrtc.org/2181803003/diff/1/webrtc/api/android/java/src/o...
File webrtc/api/android/java/src/org/webrtc/Camera2Enumerator.java (right):

https://codereview.webrtc.org/2181803003/diff/1/webrtc/api/android/java/src/o...
webrtc/api/android/java/src/org/webrtc/Camera2Enumerator.java:40: private final
static double MIN_ASPECT_RATIO_RATIO = 0.99;
On 2016/07/26 13:38:15, magjed_webrtc wrote:
> do integer comparison instead, i.e. instead of 'width1 / height1 == width2 /
> height2' do 'width1 * height2 == width2 * height1'.

Done.

https://codereview.webrtc.org/2181803003/diff/1/webrtc/api/android/java/src/o...
webrtc/api/android/java/src/org/webrtc/Camera2Enumerator.java:105: 
On 2016/07/26 13:38:15, magjed_webrtc wrote:
> nit: remove this extra line

Done.

[magjed_webrtc, 2016-07-26 14:36:45]

lgtm

[sakal, 2016-07-27 07:01:27]

The CQ bit was checked by sakal@webrtc.org

[commit-bot: I haz the power, 2016-07-27 07:01:38]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...

[commit-bot: I haz the power, 2016-07-27 08:28:47]

Description was changed from

==========
Filter to formats that match device sensor array aspect ratio on pre-LMR1
devices offering only legacy camera2 support.

There is a bug on pre LMR1 devices that only support legacy
implementation of camera2 API where aspect ratio of the camera is
incorrect if the output format doesn't match the aspect ratio of the
sensor array. On these devices, we want to disable the output formats that
have different aspect ratio.
==========

to

==========
Filter to formats that match device sensor array aspect ratio on pre-LMR1
devices offering only legacy camera2 support.

There is a bug on pre LMR1 devices that only support legacy
implementation of camera2 API where aspect ratio of the camera is
incorrect if the output format doesn't match the aspect ratio of the
sensor array. On these devices, we want to disable the output formats that
have different aspect ratio.
==========

[commit-bot: I haz the power, 2016-07-27 08:28:48]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-07-27 08:28:59]

Description was changed from

==========
Filter to formats that match device sensor array aspect ratio on pre-LMR1
devices offering only legacy camera2 support.

There is a bug on pre LMR1 devices that only support legacy
implementation of camera2 API where aspect ratio of the camera is
incorrect if the output format doesn't match the aspect ratio of the
sensor array. On these devices, we want to disable the output formats that
have different aspect ratio.
==========

to

==========
Filter to formats that match device sensor array aspect ratio on pre-LMR1
devices offering only legacy camera2 support.

There is a bug on pre LMR1 devices that only support legacy
implementation of camera2 API where aspect ratio of the camera is
incorrect if the output format doesn't match the aspect ratio of the
sensor array. On these devices, we want to disable the output formats that
have different aspect ratio.

Committed: https://crrev.com/f22d3c48fa14502cd4c8e0ffc4c1eae4d7116b6f
Cr-Commit-Position: refs/heads/master@{#13538}
==========

[commit-bot: I haz the power, 2016-07-27 08:29:00]

Patchset 2 (id:??) landed as
https://crrev.com/f22d3c48fa14502cd4c8e0ffc4c1eae4d7116b6f
Cr-Commit-Position: refs/heads/master@{#13538}