Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(193)

Issue 2180903002: flaky EndToEndTest.DecodesRetransmittedFrame adjusted (Closed)

Created:
4 years, 4 months ago by danilchap
Modified:
4 years, 4 months ago
Reviewers:
stefan-webrtc
CC:
webrtc-reviews_webrtc.org, video-team_agora.io, yujie_mao (webrtc), zhengzhonghou_agora.io, stefan-webrtc, tterriberry_mozilla.com, pbos-webrtc, perkj_webrtc, mflodman
Base URL:
https://chromium.googlesource.com/external/webrtc.git@master
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

flaky EndToEndTest.DecodesRetransmittedFrame adjusted to be aware about rare situation where packet resend before sent: Expectations reduced by validating frame was rendered after or before last packet for that frame was dropped. BUG=webrtc:5540 Committed: https://crrev.com/192717ee1ae8fa812a1c1cc04d27bcbf9b5146bf Cr-Commit-Position: refs/heads/master@{#13523}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+16 lines, -7 lines) Patch
M webrtc/video/end_to_end_tests.cc View 5 chunks +16 lines, -7 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
danilchap
expect less, concentrate on use case more (drop packet expecting resend, ensure frame was rendered. ...
4 years, 4 months ago (2016-07-25 14:52:42 UTC) #2
stefan-webrtc
lgtm
4 years, 4 months ago (2016-07-25 15:05:44 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2180903002/1
4 years, 4 months ago (2016-07-25 15:06:17 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 4 months ago (2016-07-25 15:20:55 UTC) #6
commit-bot: I haz the power
4 years, 4 months ago (2016-07-25 15:21:06 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/192717ee1ae8fa812a1c1cc04d27bcbf9b5146bf
Cr-Commit-Position: refs/heads/master@{#13523}

Powered by Google App Engine
This is Rietveld 408576698