Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2180853006:
GN conversion of audio_decoder_unittests (Closed)
|
Created:
4 years, 4 months ago by charujain Modified:
4 years, 4 months ago CC:
webrtc-reviews_webrtc.org, kwiberg-webrtc, tlegrand-webrtc, tterriberry_mozilla.com, audio-team_agora.io, hlundin-webrtc, peah-webrtc, minyue-webrtc Base URL:
https://chromium.googlesource.com/external/webrtc.git@master Target Ref:
refs/pending/heads/master Project:
webrtc Visibility:
Public. |
DescriptionGN conversion of audio_decoder_unittests
BUG=webrtc 6036
Committed: https://crrev.com/ddf3e4accd855873fd71b018ad6288c4105b5b1d
Cr-Commit-Position: refs/heads/master@{#13588}
Patch Set 1 #Patch Set 2 : GN vesion for audio_decoder_unittests #
Total comments: 1
Patch Set 3 : Added if clause for test to pass on android #
Messages
Total messages: 23 (13 generated)
The CQ bit was checked by charujain@webrtc.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...
The CQ bit was unchecked by charujain@webrtc.org
Description was changed from ========== Conversion of audio_decoder_unittests gyp to GN target, fixed android bots BUG= ========== to ========== GN conversion of audio_decoder_unittests BUG=webrtc 6036 ==========
charujain@webrtc.org changed reviewers: + phoglund@webrtc.org
lgtm
The CQ bit was checked by charujain@webrtc.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: presubmit on master.tryserver.webrtc (JOB_FAILED, http://build.chromium.org/p/tryserver.webrtc/builders/presubmit/builds/7049)
LGTM
The CQ bit was checked by charujain@webrtc.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: android_arm64_rel on master.tryserver.webrtc (JOB_FAILED, http://build.chromium.org/p/tryserver.webrtc/builders/android_arm64_rel/build...)
The CQ bit was checked by charujain@webrtc.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...
Message was sent while issue was closed.
Description was changed from ========== GN conversion of audio_decoder_unittests BUG=webrtc 6036 ========== to ========== GN conversion of audio_decoder_unittests BUG=webrtc 6036 ==========
Message was sent while issue was closed.
Committed patchset #2 (id:20001)
Message was sent while issue was closed.
Description was changed from ========== GN conversion of audio_decoder_unittests BUG=webrtc 6036 ========== to ========== GN conversion of audio_decoder_unittests BUG=webrtc 6036 Committed: https://crrev.com/ddf3e4accd855873fd71b018ad6288c4105b5b1d Cr-Commit-Position: refs/heads/master@{#13588} ==========
Message was sent while issue was closed.
Patchset 2 (id:??) landed as https://crrev.com/ddf3e4accd855873fd71b018ad6288c4105b5b1d Cr-Commit-Position: refs/heads/master@{#13588}
Message was sent while issue was closed.
kjellander@webrtc.org changed reviewers: + kjellander@webrtc.org
Message was sent while issue was closed.
Can you make another CL to make it pass on Android? https://codereview.webrtc.org/2180853006/diff/20001/webrtc/modules/audio_codi... File webrtc/modules/audio_coding/BUILD.gn (right): https://codereview.webrtc.org/2180853006/diff/20001/webrtc/modules/audio_codi... webrtc/modules/audio_coding/BUILD.gn:1034: if (is_ios) { I think this needs to be if (is_android || is_ios) { in order for the test to pass on Android. |
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
