Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(761)

Issue 2180843002: Remove unrelated checks from DecodesRetransmittedFrame* tests (Closed)

Created:
4 years, 5 months ago by danilchap
Modified:
4 years, 5 months ago
Reviewers:
stefan-webrtc
CC:
webrtc-reviews_webrtc.org, video-team_agora.io, yujie_mao (webrtc), zhengzhonghou_agora.io, stefan-webrtc, tterriberry_mozilla.com, pbos-webrtc, perkj_webrtc, mflodman
Base URL:
https://chromium.googlesource.com/external/webrtc.git@master
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Remove unrelated checks from DecodesRetransmittedFrame* tests Test was expecting no rtx packet before dropped packet. Because of prober there might be some non-padding rtx packets before nack. Those checks removed, test primary expectations are unaffected. BUG=webrtc:5540 R=stefan@webrtc.org Committed: https://crrev.com/fdd381c163bcfea5887c1bc98618a05bb55d4b80 Cr-Commit-Position: refs/heads/master@{#13522}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -10 lines) Patch
M webrtc/video/end_to_end_tests.cc View 1 chunk +2 lines, -10 lines 0 comments Download

Messages

Total messages: 9 (4 generated)
danilchap
4 years, 5 months ago (2016-07-25 08:52:21 UTC) #1
stefan-webrtc
lgtm
4 years, 5 months ago (2016-07-25 10:56:32 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2180843002/1
4 years, 5 months ago (2016-07-25 11:00:09 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 5 months ago (2016-07-25 11:03:24 UTC) #7
commit-bot: I haz the power
4 years, 5 months ago (2016-07-25 11:03:31 UTC) #9
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/fdd381c163bcfea5887c1bc98618a05bb55d4b80
Cr-Commit-Position: refs/heads/master@{#13522}

Powered by Google App Engine
This is Rietveld 408576698