Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(467)

Issue 2179903004: Fix a memory leak where EventLogger is created two times in the event tracer. (Closed)

Created:
4 years, 4 months ago by sakal
Modified:
4 years, 4 months ago
Reviewers:
tommi
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com
Base URL:
https://chromium.googlesource.com/external/webrtc.git@master
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Fix a memory leak where EventLogger is created two times in the event tracer. R=tommi@webrtc.org Committed: https://crrev.com/bb19a60832a95b206e706042f747a987602dd5b6 Cr-Commit-Position: refs/heads/master@{#13536}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -1 line) Patch
M webrtc/base/event_tracer.cc View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 11 (6 generated)
sakal
Tommi, PTAL.
4 years, 4 months ago (2016-07-26 14:21:07 UTC) #3
tommi
lgtm Yikes
4 years, 4 months ago (2016-07-26 17:37:46 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2179903004/1
4 years, 4 months ago (2016-07-26 17:37:53 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 4 months ago (2016-07-26 17:39:11 UTC) #9
commit-bot: I haz the power
4 years, 4 months ago (2016-07-26 17:39:18 UTC) #11
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/bb19a60832a95b206e706042f747a987602dd5b6
Cr-Commit-Position: refs/heads/master@{#13536}

Powered by Google App Engine
This is Rietveld 408576698