Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2179753003:
Memset svc_params in vp9 wrapper to avoid undefined behavior. (Closed)
DescriptionMemset svc_params in vp9 wrapper to avoid undefined behavior.
Due to a recent interface change for svc_params in vp9 svc, which
allows speed setting per layer, svc_params should be inited to 0
for safety.
Committed: https://crrev.com/8bc773430f23544a39ca765776801385d4ae16c0
Cr-Commit-Position: refs/heads/master@{#13561}
Patch Set 1 #Patch Set 2 : Comment updated. #
Messages
Total messages: 19 (11 generated)
Description was changed from ========== Memset svc_params in vp9 wrapper to avoid undefined behavior. Due to interface change for svc_params, it should be initialized to 0 at the beginning to be safe. BUG= ========== to ========== Memset svc_params in vp9 wrapper to avoid undefined behavior. Due to interface change for svc_params, it should be initialized to 0 at the beginning to be safe. BUG= ==========
jackychen@webrtc.org changed reviewers: + marpan@webrtc.org
Description was changed from ========== Memset svc_params in vp9 wrapper to avoid undefined behavior. Due to interface change for svc_params, it should be initialized to 0 at the beginning to be safe. BUG= ========== to ========== Memset svc_params in vp9 wrapper to avoid undefined behavior. Due to a recent interface change for svc_params in vp9 svc, which allows speed setting per layer, svc_params should be inited to 0 for safety. ==========
Description was changed from ========== Memset svc_params in vp9 wrapper to avoid undefined behavior. Due to a recent interface change for svc_params in vp9 svc, which allows speed setting per layer, svc_params should be inited to 0 for safety. ========== to ========== Memset svc_params in vp9 wrapper to avoid undefined behavior. Due to a recent interface change for svc_params in vp9 svc, which allows speed setting per layer, svc_params should be inited to 0 for safety. ==========
jackychen@google.com changed reviewers: + mflodman@webrtc.org, sprang@webrtc.org
jackychen@google.com changed reviewers: + jackychen@google.com
marpan@google.com changed reviewers: + marpan@google.com
lgtm
sprang@webrtc.org changed reviewers: + stefan@webrtc.org - jackychen@google.com, marpan@google.com, mflodman@webrtc.org
lgtm +stefan
lgtm
The CQ bit was checked by jackychen@webrtc.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...
Message was sent while issue was closed.
Description was changed from ========== Memset svc_params in vp9 wrapper to avoid undefined behavior. Due to a recent interface change for svc_params in vp9 svc, which allows speed setting per layer, svc_params should be inited to 0 for safety. ========== to ========== Memset svc_params in vp9 wrapper to avoid undefined behavior. Due to a recent interface change for svc_params in vp9 svc, which allows speed setting per layer, svc_params should be inited to 0 for safety. ==========
Message was sent while issue was closed.
Committed patchset #2 (id:20001)
Message was sent while issue was closed.
Description was changed from ========== Memset svc_params in vp9 wrapper to avoid undefined behavior. Due to a recent interface change for svc_params in vp9 svc, which allows speed setting per layer, svc_params should be inited to 0 for safety. ========== to ========== Memset svc_params in vp9 wrapper to avoid undefined behavior. Due to a recent interface change for svc_params in vp9 svc, which allows speed setting per layer, svc_params should be inited to 0 for safety. Committed: https://crrev.com/8bc773430f23544a39ca765776801385d4ae16c0 Cr-Commit-Position: refs/heads/master@{#13561} ==========
Message was sent while issue was closed.
Patchset 2 (id:??) landed as https://crrev.com/8bc773430f23544a39ca765776801385d4ae16c0 Cr-Commit-Position: refs/heads/master@{#13561} |
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
