Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(214)

Issue 2177873003: iOS HW encoder: Increase data rate limit (Closed)

Created:
4 years, 5 months ago by magjed_webrtc
Modified:
4 years, 5 months ago
Reviewers:
tkchin_webrtc
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com, zhengzhonghou_agora.io, video-team_agora.io, stefan-webrtc, mflodman
Base URL:
https://chromium.googlesource.com/external/webrtc.git@master
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

iOS HW encoder: Increase data rate limit The iOS H264 video toolbox encoder is currently undershooting the intended bitrate. This seems to be caused by the data rate limit property. This CL increases the data rate limit to a set percentage above the intended bitrate to avoid undershooting. The AverageBitRate property is still set to the intended bitrate, which keeps it from overshooting the intended bitrate. BUG=b/28713684 Committed: https://crrev.com/62d695f6550cb8577191f00af9df76c4d8474afc Cr-Commit-Position: refs/heads/master@{#13526}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -2 lines) Patch
M webrtc/modules/video_coding/codecs/h264/h264_video_toolbox_encoder.cc View 2 chunks +8 lines, -2 lines 0 comments Download

Messages

Total messages: 10 (5 generated)
magjed_webrtc
zeke - please take a look.
4 years, 5 months ago (2016-07-25 16:26:38 UTC) #3
tkchin_webrtc
On 2016/07/25 16:26:38, magjed_webrtc wrote: > zeke - please take a look. lgtm
4 years, 5 months ago (2016-07-25 21:11:44 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2177873003/1
4 years, 5 months ago (2016-07-26 09:11:55 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 5 months ago (2016-07-26 10:10:37 UTC) #8
commit-bot: I haz the power
4 years, 5 months ago (2016-07-26 10:10:41 UTC) #10
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/62d695f6550cb8577191f00af9df76c4d8474afc
Cr-Commit-Position: refs/heads/master@{#13526}

Powered by Google App Engine
This is Rietveld 408576698