Chromium Code Reviews

Issue 2177523002: Fix issues with RestartingSendStreamPreservesRtpStatesWithRtx (Closed)

Created:
4 years, 5 months ago by danilchap
Modified:
4 years, 4 months ago
Reviewers:
stefan-webrtc
CC:
webrtc-reviews_webrtc.org, video-team_agora.io, danilchap, yujie_mao (webrtc), zhuangzesen_agora.io, zhengzhonghou_agora.io, stefan-webrtc, tterriberry_mozilla.com, pbos-webrtc, perkj_webrtc, mflodman
Base URL:
https://chromium.googlesource.com/external/webrtc.git@master
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Fix issues with RestartingSendStreamPreservesRtpStatesWithRtx double check rtp_sender in sending mode when altering sequence_number adjust test to skip validating timestamp on rtx streams fix test by waiting for all 3 media streams instead of 3 out 6 media and rtx streams. BUG=webrtc:4332 Committed: https://crrev.com/32cd2c4103e7a84a5167a59973054dfca92bae74 Cr-Commit-Position: refs/heads/master@{#13587}

Patch Set 1 #

Patch Set 2 : rebase #

Unified diffs Side-by-side diffs Stats (+34 lines, -24 lines)
M webrtc/modules/rtp_rtcp/source/rtp_sender.h View 1 chunk +1 line, -2 lines 0 comments
M webrtc/modules/rtp_rtcp/source/rtp_sender.cc View 4 chunks +9 lines, -2 lines 0 comments
M webrtc/modules/rtp_rtcp/source/rtp_sender_audio.cc View 1 chunk +5 lines, -2 lines 0 comments
M webrtc/modules/rtp_rtcp/source/rtp_sender_video.cc View 1 chunk +4 lines, -2 lines 0 comments
M webrtc/video/end_to_end_tests.cc View 5 chunks +15 lines, -16 lines 0 comments

Messages

Total messages: 15 (8 generated)
danilchap
Before the changes the test failed every ~100 runs. After the changes run it 40000 ...
4 years, 5 months ago (2016-07-22 15:30:19 UTC) #3
stefan-webrtc
lgtm
4 years, 4 months ago (2016-08-01 11:17:04 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2177523002/1
4 years, 4 months ago (2016-08-01 11:29:37 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: android_compile_x64_dbg on master.tryserver.webrtc (JOB_FAILED, http://build.chromium.org/p/tryserver.webrtc/builders/android_compile_x64_dbg/builds/5669) android_compile_x86_dbg on master.tryserver.webrtc (JOB_FAILED, ...
4 years, 4 months ago (2016-08-01 11:30:47 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2177523002/20001
4 years, 4 months ago (2016-08-01 13:55:59 UTC) #11
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 4 months ago (2016-08-01 13:58:39 UTC) #13
commit-bot: I haz the power
4 years, 4 months ago (2016-08-01 13:58:48 UTC) #15
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/32cd2c4103e7a84a5167a59973054dfca92bae74
Cr-Commit-Position: refs/heads/master@{#13587}

Powered by Google App Engine