Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(54)

Issue 2177473002: Remove suppression for non-existing test. (Closed)

Created:
4 years, 5 months ago by mflodman
Modified:
4 years, 5 months ago
Reviewers:
pbos-webrtc
CC:
webrtc-reviews_webrtc.org
Base URL:
https://chromium.googlesource.com/external/webrtc.git@master
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -13 lines) Patch
M tools/valgrind-webrtc/memcheck/suppressions.txt View 1 chunk +0 lines, -13 lines 0 comments Download

Messages

Total messages: 11 (5 generated)
mflodman
pbos, Please take a look.
4 years, 5 months ago (2016-07-22 11:19:01 UTC) #1
pbos-webrtc
lgtm if you can personally guarantee that this is safe.. ... ;)
4 years, 5 months ago (2016-07-22 11:33:54 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2177473002/1
4 years, 5 months ago (2016-07-22 11:56:27 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: linux_libfuzzer_rel on master.tryserver.webrtc (JOB_FAILED, http://build.chromium.org/p/tryserver.webrtc/builders/linux_libfuzzer_rel/builds/4020)
4 years, 5 months ago (2016-07-22 12:06:34 UTC) #7
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/d4e6cbdbbe52fdfa120c0ebb74faf8ddb3f9a4f1 Cr-Commit-Position: refs/heads/master@{#13509}
4 years, 5 months ago (2016-07-22 13:36:07 UTC) #10
mflodman
4 years, 5 months ago (2016-07-22 13:36:07 UTC) #11
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
d4e6cbdbbe52fdfa120c0ebb74faf8ddb3f9a4f1 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698