Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(158)

Unified Diff: webrtc/voice_engine/include/voe_codec.h

Issue 2177263002: Regression test for issue where Opus DTX status was being forgotten. (Closed) Base URL: https://chromium.googlesource.com/external/webrtc.git@master
Patch Set: Renamed GetOpusDtx to GetOpusDtxStatus to avoid naming conflict with FakeWebRtcVoiceEngine. Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « webrtc/voice_engine/channel.cc ('k') | webrtc/voice_engine/voe_codec_impl.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: webrtc/voice_engine/include/voe_codec.h
diff --git a/webrtc/voice_engine/include/voe_codec.h b/webrtc/voice_engine/include/voe_codec.h
index 5d94ac27365a91fa3df47901f28ad66422ab7b4f..cedf47d6b9ddf3e963d73f21fc7d8caaa080cc20 100644
--- a/webrtc/voice_engine/include/voe_codec.h
+++ b/webrtc/voice_engine/include/voe_codec.h
@@ -131,6 +131,12 @@ class WEBRTC_DLLEXPORT VoECodec {
// success, and -1 if failed.
virtual int SetOpusDtx(int channel, bool enable_dtx) = 0;
+ // If send codec is Opus on a specified |channel|, return its DTX status.
+ // Returns 0 on success, and -1 if failed.
+ // TODO(ivoc): Make GetOpusDtxStatus() pure virtual when all deriving classes
+ // are updated.
+ virtual int GetOpusDtxStatus(int channel, bool* enabled) { return -1; }
+
protected:
VoECodec() {}
virtual ~VoECodec() {}
« no previous file with comments | « webrtc/voice_engine/channel.cc ('k') | webrtc/voice_engine/voe_codec_impl.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698