webrtc/modules/audio_coding/codecs/opus/audio_encoder_opus.h - Issue 2177263002: Regression test for issue where Opus DTX status was being forgotten.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: webrtc/modules/audio_coding/codecs/opus/audio_encoder_opus.h

Issue 2177263002: Regression test for issue where Opus DTX status was being forgotten. (Closed) Base URL: https://chromium.googlesource.com/external/webrtc.git@master

Patch Set: Renamed GetOpusDtx to GetOpusDtxStatus to avoid naming conflict with FakeWebRtcVoiceEngine. Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « webrtc/modules/audio_coding/codecs/audio_encoder.cc ('k') | webrtc/modules/audio_coding/codecs/opus/audio_encoder_opus.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: webrtc/modules/audio_coding/codecs/opus/audio_encoder_opus.h

diff --git a/webrtc/modules/audio_coding/codecs/opus/audio_encoder_opus.h b/webrtc/modules/audio_coding/codecs/opus/audio_encoder_opus.h

index 367c9b90eae5421424683a8f6ece8f919ed02de8..48fb494dbe180bb7b151c5fe36767c83c84411be 100644

--- a/webrtc/modules/audio_coding/codecs/opus/audio_encoder_opus.h

+++ b/webrtc/modules/audio_coding/codecs/opus/audio_encoder_opus.h

@@ -75,6 +75,7 @@ class AudioEncoderOpus final : public AudioEncoder {

// being inactive. During that, it still sends 2 packets (one for content, one

// for signaling) about every 400 ms.

bool SetDtx(bool enable) override;

+ bool GetDtx() const override;

bool SetApplication(Application application) override;

void SetMaxPlaybackRate(int frequency_hz) override;

@@ -84,7 +85,6 @@ class AudioEncoderOpus final : public AudioEncoder {

// Getters for testing.

double packet_loss_rate() const { return packet_loss_rate_; }

ApplicationMode application() const { return config_.application; }

- bool dtx_enabled() const { return config_.dtx_enabled; }

protected:

EncodedInfo EncodeImpl(uint32_t rtp_timestamp,