Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(205)

Unified Diff: webrtc/modules/audio_coding/include/audio_coding_module.h

Issue 2177263002: Regression test for issue where Opus DTX status was being forgotten. (Closed) Base URL: https://chromium.googlesource.com/external/webrtc.git@master
Patch Set: Initial version. Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: webrtc/modules/audio_coding/include/audio_coding_module.h
diff --git a/webrtc/modules/audio_coding/include/audio_coding_module.h b/webrtc/modules/audio_coding/include/audio_coding_module.h
index 5b35bcf7a5443317343a7d003ad1ec28458f874c..0e440423fcceca8e5d1472408c54697644cdbf16 100644
--- a/webrtc/modules/audio_coding/include/audio_coding_module.h
+++ b/webrtc/modules/audio_coding/include/audio_coding_module.h
@@ -766,6 +766,16 @@ class AudioCodingModule {
virtual int DisableOpusDtx() = 0;
///////////////////////////////////////////////////////////////////////////
+ // int GetOpusDtx()
minyue-webrtc 2016/07/25 16:13:01 I think we can avoid introducing this function by
ivoc 2016/07/25 17:11:09 Good point, that is indeed a better approach. I ad
+ // If current send codec is Opus, get the status of its internal DTX.
+ //
+ // Return value:
+ // -1 if current send codec is not Opus.
+ // 0 if the Opus DTX status is written to |enabled| successfully.
+ //
+ virtual int GetOpusDtx(bool* enabled) = 0;
+
+ ///////////////////////////////////////////////////////////////////////////
// statistics
//

Powered by Google App Engine
This is Rietveld 408576698