Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(215)

Unified Diff: webrtc/modules/audio_coding/codecs/opus/audio_encoder_opus.cc

Issue 2177263002: Regression test for issue where Opus DTX status was being forgotten. (Closed) Base URL: https://chromium.googlesource.com/external/webrtc.git@master
Patch Set: Initial version. Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: webrtc/modules/audio_coding/codecs/opus/audio_encoder_opus.cc
diff --git a/webrtc/modules/audio_coding/codecs/opus/audio_encoder_opus.cc b/webrtc/modules/audio_coding/codecs/opus/audio_encoder_opus.cc
index edafbbdf39d9f64449395209bde4941a2df8d66f..51b0843e09792cdbf84d0d62fa71c01ed5a2539d 100644
--- a/webrtc/modules/audio_coding/codecs/opus/audio_encoder_opus.cc
+++ b/webrtc/modules/audio_coding/codecs/opus/audio_encoder_opus.cc
@@ -152,6 +152,10 @@ bool AudioEncoderOpus::SetDtx(bool enable) {
return RecreateEncoderInstance(conf);
}
+bool AudioEncoderOpus::GetDtx() {
minyue-webrtc 2016/07/25 16:13:01 why to add another function since dtx_enabled() ex
ivoc 2016/07/25 17:11:09 The function needs to be on the AudioEncoder inter
minyue-webrtc 2016/07/26 09:37:01 Ok. Can you remove AudioEncoderOpus::dtx_enabled()
ivoc 2016/07/26 12:28:31 It's already gone :-)
minyue-webrtc 2016/07/26 15:04:54 Oh, yes, sorry. I missed that one
+ return dtx_enabled();
+}
+
bool AudioEncoderOpus::SetApplication(Application application) {
auto conf = config_;
switch (application) {

Powered by Google App Engine
This is Rietveld 408576698