Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(341)

Side by Side Diff: webrtc/voice_engine/include/voe_codec.h

Issue 2177263002: Regression test for issue where Opus DTX status was being forgotten. (Closed) Base URL: https://chromium.googlesource.com/external/webrtc.git@master
Patch Set: Addressed review comments. Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright (c) 2012 The WebRTC project authors. All Rights Reserved. 2 * Copyright (c) 2012 The WebRTC project authors. All Rights Reserved.
3 * 3 *
4 * Use of this source code is governed by a BSD-style license 4 * Use of this source code is governed by a BSD-style license
5 * that can be found in the LICENSE file in the root of the source 5 * that can be found in the LICENSE file in the root of the source
6 * tree. An additional intellectual property rights grant can be found 6 * tree. An additional intellectual property rights grant can be found
7 * in the file PATENTS. All contributing project authors may 7 * in the file PATENTS. All contributing project authors may
8 * be found in the AUTHORS file in the root of the source tree. 8 * be found in the AUTHORS file in the root of the source tree.
9 */ 9 */
10 10
(...skipping 113 matching lines...) Expand 10 before | Expand all | Expand 10 after
124 // TODO(minyue): Make SetOpusMaxPlaybackRate() pure virtual when 124 // TODO(minyue): Make SetOpusMaxPlaybackRate() pure virtual when
125 // fakewebrtcvoiceengine in talk is ready. 125 // fakewebrtcvoiceengine in talk is ready.
126 virtual int SetOpusMaxPlaybackRate(int channel, int frequency_hz) { 126 virtual int SetOpusMaxPlaybackRate(int channel, int frequency_hz) {
127 return -1; 127 return -1;
128 } 128 }
129 129
130 // If send codec is Opus on a specified |channel|, set its DTX. Returns 0 if 130 // If send codec is Opus on a specified |channel|, set its DTX. Returns 0 if
131 // success, and -1 if failed. 131 // success, and -1 if failed.
132 virtual int SetOpusDtx(int channel, bool enable_dtx) = 0; 132 virtual int SetOpusDtx(int channel, bool enable_dtx) = 0;
133 133
134 // If send codec is Opus on a specified |channel|, return its DTX status.
135 // Returns 0 on success, and -1 if failed.
136 virtual int GetOpusDtx(int channel, bool* enabled) { return -1; }
henrika_webrtc 2016/07/27 09:32:59 Why default implementation?
ivoc 2016/07/27 09:48:32 This is a public API, and there is code outside of
137
134 protected: 138 protected:
135 VoECodec() {} 139 VoECodec() {}
136 virtual ~VoECodec() {} 140 virtual ~VoECodec() {}
137 }; 141 };
138 142
139 } // namespace webrtc 143 } // namespace webrtc
140 144
141 #endif // WEBRTC_VOICE_ENGINE_VOE_CODEC_H 145 #endif // WEBRTC_VOICE_ENGINE_VOE_CODEC_H
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698